Skip to content

Commit

Permalink
draft changes
Browse files Browse the repository at this point in the history
Signed-off-by: Anatoly Myachev <[email protected]>
  • Loading branch information
anmyachev committed Jul 6, 2023
1 parent 27e2e41 commit 2c9e895
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 3 deletions.
12 changes: 9 additions & 3 deletions modin/pandas/series.py
Original file line number Diff line number Diff line change
Expand Up @@ -716,9 +716,14 @@ def compare(
result_names=result_names,
)
if align_axis == "columns" or align_axis == 1:
# Pandas.DataFrame.Compare returns a dataframe with a multidimensional index object as the
# columns so we have to change column object back.
result.columns = pandas.Index(["self", "other"])
if len(result.columns):
# Pandas.DataFrame.Compare returns a dataframe with a multidimensional index object as the
# columns so we have to change column object back.
result.columns = pandas.Index(result_names)
else:
from .dataframe import DataFrame

result = DataFrame([], index=[], columns=result_names)
else:
result = result.squeeze().rename(None)
return result
Expand Down Expand Up @@ -1444,6 +1449,7 @@ def rename(
non_mapping = is_scalar(index) or (
is_list_like(index) and not is_dict_like(index)
)
breakpoint()
if non_mapping:
if inplace:
self.name = index
Expand Down
12 changes: 12 additions & 0 deletions modin/pandas/test/dataframe/test_join_sort.py
Original file line number Diff line number Diff line change
Expand Up @@ -929,3 +929,15 @@ def test_compare(align_axis, keep_shape, keep_equal):
modin_result = modin_series2.compare(modin_series1, **kwargs)
pandas_result = pandas_series2.compare(pandas_series1, **kwargs)
assert to_pandas(modin_result).equals(pandas_result)

series_data = 1
pandas_series = pandas.Series(series_data)
modin_series = pd.Series(series_data)

modin_result = modin_series.compare(modin_series, **kwargs)
pandas_result = pandas_series.compare(pandas_series, **kwargs)
assert to_pandas(modin_result).equals(pandas_result)

modin_result = modin_series.compare(modin_series, result_names=("left", "right"), **kwargs)
pandas_result = pandas_series.compare(pandas_series, result_names=("left", "right"), **kwargs)
assert to_pandas(modin_result).equals(pandas_result)

0 comments on commit 2c9e895

Please sign in to comment.