Apply suggestions from code review

Co-authored-by: Iaroslav Igoshev <[email protected]>
anmyachev · May 13, 2024 · 3090e09 · 3090e09
1 parent 0b30e13
commit 3090e09
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/modin/core/dataframe/pandas/partitioning/partition_manager.py b/modin/core/dataframe/pandas/partitioning/partition_manager.py
@@ -192,7 +192,9 @@ def create_partition_from_metadata(
         Parameters
         ----------
         dtypes : pandas.Series, optional
-            Dtypes that will be used when calling `astype`.
+            Column dtypes.
+            Upon creating a pandas DataFrame from `metadata` we call `astype` since
+            pandas doesn't allow to pass a list of dtypes directly in the constructor.
         **metadata : dict
             Metadata that has to be wrapped in a partition.
 

diff --git a/modin/tests/pandas/dataframe/test_join_sort.py b/modin/tests/pandas/dataframe/test_join_sort.py
@@ -81,7 +81,7 @@ def test_combine(data):
     [
         (
             np.random.randint(0, 100, size=(64, 64)),
-            np.random.uniform(0, 100, size=(128, 64)),
+            np.random.randint(0, 100, size=(128, 64)),
         ),
         (
             np.random.randint(0, 100, size=(128, 64)),