Skip to content

Commit

Permalink
TEST-#0000: update python version for ASV benchmarks on HDK
Browse files Browse the repository at this point in the history
Signed-off-by: Anatoly Myachev <[email protected]>
  • Loading branch information
anmyachev committed Aug 23, 2023
1 parent 54fd6c1 commit adc68de
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,10 @@ jobs:
sed -i 's/def time_groupby_agg_nunique(self, \*args, \*\*kwargs):/# def time_groupby_agg_nunique(self, *args, **kwargs):/g' benchmarks/hdk/benchmarks.py
sed -i 's/execute(self.df.groupby(by=self.groupby_columns).agg("nunique"))/# execute(self.df.groupby(by=self.groupby_columns).agg("nunique"))/g' benchmarks/hdk/benchmarks.py
# Otherwise, ASV considers that the environment has already been created, although ASV command is run for another config,
# which requires the creation of a completely new environment. This step will be required after removing the manual environment setup step.
rm -f -R .asv/env/
# TODO: Remove manual environment creation after fix https://github.com/airspeed-velocity/asv/issues/1310
mamba env create -f ../requirements/env_hdk.yml
conda activate modin_on_hdk
Expand Down
2 changes: 1 addition & 1 deletion asv_bench/asv.conf.hdk.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

// The Pythons you'd like to test against. If not provided, defaults
// to the current version of Python used to run `asv`.
"pythons": ["3.7"],
"pythons": ["3.8"],

// The list of conda channel names to be searched for benchmark
// dependency packages in the specified order
Expand Down
4 changes: 4 additions & 0 deletions asv_bench/asv.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@
// the base URL to show a commit for the project.
"show_commit_url": "https://github.com/modin-project/modin/commit/",

// The Pythons you'd like to test against. If not provided, defaults
// to the current version of Python used to run `asv`.
"pythons": ["3.8"],

// The Pythons you'd like to test against. If not provided, defaults
// to the current version of Python used to run `asv`.
// "pythons": ["3.7"],
Expand Down

0 comments on commit adc68de

Please sign in to comment.