[pull] main from microsoft:main #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
## Summary of the Pull Request > ## Abstract > > _"Shell integration" refers to a broad category of ways by which a commandline > shell can drive richer integration with the terminal. This spec in particular is > most concerned with "marks" and other semantic markup of the buffer._ > > Marks are a new buffer-side feature that allow the commandline application or > user to add a bit of metadata to a range of text. This can be used for marking a > region of text as a prompt, marking a command as succeeded or failed, quickly > marking errors in the output. These marks can then be exposed to the user as > pips on the scrollbar, or as icons in the margins. Additionally, the user can > quickly scroll between different marks, to allow easy navigation between > important information in the buffer. > > Marks in the Windows Terminal are a combination of functionality from a variety > of different terminal emulators. "Marks" attmepts to unify these different, but > related pieces of functionality. ## Detailed Description of the Pull Request / Additional comments _\*<sup>\*</sup><sub>\*</sub> read the spec <sub>\*</sub><sup>\*</sup>\*_ In all seriousness, I've already implemented a pile of this. This is just putting the finishing touches of formalizing it. ## PR Checklist - [x] This is a spec for #11000 and everything linked to that.
Replace deprecated winrt::apartment_context pattern I only found 2 instances of this pattern in use and one of them was actually already replaced but the `co_await winrt::apartment_context` code was still there. Tested both window renaming and opening terminal with persisted layouts. Both still work. Closes #12982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )