Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ec2_vpc_route_table to support associating internet gateways #476

Closed
1 task done
nicorusti opened this issue Aug 18, 2021 · 3 comments · Fixed by #690
Closed
1 task done

Update ec2_vpc_route_table to support associating internet gateways #476

nicorusti opened this issue Aug 18, 2021 · 3 comments · Fixed by #690
Labels
feature This issue/PR relates to a feature request jira module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@nicorusti
Copy link

Summary

Update ec2_vpc_route_table to support associating internet gateways to route tables. Currently, this module only supports associating subnets to a route table.

Adding support for associating Internet Gateways will make it much easier to configure VPC Ingress Routing .

Issue Type

Feature Idea

Component Name

ec2_vpc_route_table

Additional Information

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@nicorusti nicorusti changed the title Update ec2_vpc_route_table to support Update ec2_vpc_route_table to support associating internet gateways Aug 18, 2021
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@tremble tremble transferred this issue from ansible-collections/community.aws Aug 27, 2021
@ansibullbot
Copy link

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Aug 27, 2021
@abikouo abikouo added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage labels Aug 31, 2021
mdellweg pushed a commit to mdellweg/amazon.aws that referenced this issue Sep 16, 2021
* fix key error when ec2 instance has no tags
* add changelog fragment
softwarefactory-project-zuul bot pushed a commit that referenced this issue Mar 29, 2022
ec2_vpc_route_table - support associating internet gateways

Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY

Update ec2_vpc_route_table to support associating internet gateways per feature request #476
Add integration tests
Fix idempotency issue when associating a subnet with a route table

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_route_table

Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Mark Woolley <[email protected]>
patchback bot pushed a commit that referenced this issue Mar 29, 2022
ec2_vpc_route_table - support associating internet gateways

Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY

Update ec2_vpc_route_table to support associating internet gateways per feature request #476
Add integration tests
Fix idempotency issue when associating a subnet with a route table

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_route_table

Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Mark Woolley <[email protected]>
(cherry picked from commit d9d5d0d)
softwarefactory-project-zuul bot pushed a commit that referenced this issue Mar 29, 2022
)

[PR #690/d9d5d0d7 backport][stable-3] ec2_vpc_route_table - support associating internet gateways

This is a backport of PR #690 as merged into main (d9d5d0d).
Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY

Update ec2_vpc_route_table to support associating internet gateways per feature request #476
Add integration tests
Fix idempotency issue when associating a subnet with a route table

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_route_table
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this issue Mar 31, 2022
…collections#690) (ansible-collections#757)

[PR ansible-collections#690/d9d5d0d7 backport][stable-3] ec2_vpc_route_table - support associating internet gateways

This is a backport of PR ansible-collections#690 as merged into main (d9d5d0d).
Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY

Update ec2_vpc_route_table to support associating internet gateways per feature request ansible-collections#476
Add integration tests
Fix idempotency issue when associating a subnet with a route table

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_route_table
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
* fix key error when ec2 instance has no tags
* add changelog fragment
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
* fix key error when ec2 instance has no tags
* add changelog fragment
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
* fix key error when ec2 instance has no tags
* add changelog fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request jira module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants