-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Add integration tests splitter github actions #1391
Conversation
9abc12f
to
61f0cf6
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 11s |
- name: Checkout the collection repository | ||
uses: actions/checkout@v3 | ||
with: | ||
path: ${{ env.source_directory }} | ||
ref: ${{ github.event.pull_request.head.sha }} | ||
fetch-depth: 0 | ||
|
||
- name: Checkout the community.aws collection repository | ||
uses: actions/checkout@v3 | ||
with: | ||
repository: ansible-collections/community.aws | ||
path: ${{ env.dependent_directory }} | ||
ref: ${{ github.event.pull_request.base.ref }} | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the collection and collection dependencies install should be handled in a separate job, or more likely a separate reusable workflow. We are reinventing the wheel here with every workflow/action, and each time we do it differently. The docs-build seems to do this its own way, the network sanity workflow does this its own way, and then we're adding a new way of doing it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am working on something that can take care of the dependencies resolution, the collection and collection dependencies install will be done with the depends-on
feature we used to add with zuul
61f0cf6
to
98f9a54
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 28s |
replaced by #1516 because we need a PR from the repository to test with pull_request_target |
Add ansible test splitter into Github actions
ISSUE TYPE