Logic for nested HttpRequestMethodConfig Values

[bradleypettit]

SUMMARY

Fixes #187. Adds logic to the compare_condition function to suit when the 'Values' key is nested within 'HttpRequestMethodConfig'. Otherwise trying to access 'Values' directly throws "KeyError: 'Values'".

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

elbv2.py

ADDITIONAL INFORMATION

As per Boto docs, when condition Field is equal to 'http-request-method', the 'Values' list should then be nested within 'HttpRequestMethodConfig' dict.

[bradleypettit]

I've found that the issue I was experiencing with HttpRequestMethodConfig applies to all other field categories with the exception of SourceIpConfig. SourceIpConfig already had a similar condition to the ones I have added for other fields.

Updated the linked issue with additional detail and updated this PR to resolve issue for all possible condition field options.

I believe this PR also fixes ansible-collections/community.aws#117

[bradleypettit]

Found that while adding support for using HostHeaderConfig or PathPatternConfig I'd inadvertantly impacted cases when Values was defined directly instead.

This is specific to the Boto3 behaviour where Conditions['Values'] (Docs) is defined as "The condition value. Specify only when Field is host-header or path-pattern . Alternatively, to specify multiple host names or multiple path patterns, use HostHeaderConfig or PathPatternConfig ."

For example when _compare_condition is running against an ALB with an existing host-header field, the current_condition object is represented as:

{
'Field': 'host-header',
'HostHeaderConfig': { 'Values': ['host.1'] }
'Values': ['host.1']
}

As a result, my original update was then always trying to compare HostHeaderConfig['Values'], however it is expected that in ansible you can use either Values or HostHeaderConfig.

While I've used host-header (HostHeaderConfig) primarily in the above example - the same applies to path-pattern (PathPatternConfig).

To cater for both possible methods of configuration, I've updated the conditions to only use HostHeaderConfig or PathPatternConfig for comparison if both current_condition and condition contain the Config dict, otherwise fallback to the pre-existing Values compare.

[goneri]

Hi @bradleypettit,

The patch indeed seems to fix ansible-collections/community.aws#117 too. I need more time to review it completely.
Thank you for your contribution! My goal is to get it merged quickly now.

[goneri]

I would like to land ansible-collections/community.aws#347 with this PR, there is a couple of CI-related issues to address first.

[goneri]

This feature depends on boto3 June 13, 2019:

AWS::ElasticLoadBalancingV2::ListenerRule
In the RuleCondition property type:
Use the HostHeaderConfig property to specify information for a host header condition.
Use the HttpHeaderConfig property to specify information for an HTTP header condition.
Use the HttpRequestMethodConfig property to specify information for an HTTP method condition.
Use the PathPatternConfig property to specify information for a path pattern condition.
Use the QueryStringConfig property to specify information for a query string condition.
Use the SourceIpConfig property to specify information for a source IP condition.

See: https://forums.aws.amazon.com/thread.jspa?messageID=897663