make dict comprehension contingent on 'not None'

[nbargnesi]

SUMMARY

Fixes #1953

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

modules.plugin.s3_object

ADDITIONAL INFORMATION

Makes it so max_keys: 0 gets added to the URI request parameters.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/961e22d8c219444e8b8ea628530f3493

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 14m 14s
✔️ ansible-test-splitter SUCCESS in 5m 14s
✔️ integration-amazon.aws-1 SUCCESS in 12m 51s
Skipped 43 jobs

[tremble]

Thanks for taking the time to submit this PR,

a couple of things:

• Please add a changelog fragment: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
• Might be better to use scrub_none_parameters(): https://github.com/ansible-collections/amazon.aws/blob/main/plugins/module_utils/transformation.py#L110
• To help avoid regressions, please add an integration test which demonstrates the expected vs current behaviour: https://github.com/ansible-collections/amazon.aws/blob/main/tests/integration/targets/s3_object/tasks/main.yml

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e5361e236e264a77b14651f2700644d5

✔️ ansible-galaxy-importer SUCCESS in 5m 07s
✔️ build-ansible-collection SUCCESS in 15m 59s
✔️ ansible-test-splitter SUCCESS in 6m 59s
✔️ integration-amazon.aws-1 SUCCESS in 13m 35s
Skipped 43 jobs

[tremble]

Thanks for taking the time to submit this PR, and I'm sorry it took so long to get back to you.

We've done some additional testing behind the scenes (see #2294).

Because the pagination is still enabled in this PR, it wouldn't fix the actual issue (ie there will still be a lot of API calls). I'm reworking how this is handled in #2328 which will (hopefully) finally fix the issue.