Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configure_ci tool to scaffold gh workflows #2094

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

GomathiselviS
Copy link
Collaborator

SUMMARY

This PR has the workflow files scaffolded by the configure_ci tool.

ansible-2.14 has been added to tox-ansible.ini under [skip], as we are dropping support for ansible-core < 2.15

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

units:
uses: ./.github/workflows/units.yml # use the callable units job to run tests
uses: ansible-network/github_actions/.github/workflows/unit_source.yml@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the unit workflow from ansible-content-actions not do what we need?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansible-content-actions run the unit tests on the galaxy version of the collection. It uses tox-ansible which lacks the capabilities to do a source install.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about this? When I run tox-ansible locally it looks to me like it's using my local copy. The way I read the docs for the action is that it installs the collection's dependencies from galaxy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reaching out to the devtools team regarding this issue. It wasn't functioning earlier, and I'm not sure if there have been any alterations in tox-ansible. Currently, there isn't a workflow in ansible-content-actions to execute unit tests on the source.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct. Sorry for the confusion. tox-ansible pulls dependencies from Galaxy, not the source.

@tremble
Copy link
Contributor

tremble commented Aug 30, 2024

@GomathiselviS Has this PR been abandoned?

Copy link
Contributor

@GomathiselviS
Copy link
Collaborator Author

@GomathiselviS Has this PR been abandoned?

No, it hasn't been abandoned; rather, it has been moved to the backlog to prioritize high-impact tasks. I will resume work on it once I receive clarity on the ansible-content-actions from the devtools team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants