Move module_utils out of subdir (final step) #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flowerysong
changed the title
flowerysong
changed the title
jillr
reviewed
Jun 17, 2020
There was a problem hiding this comment.
In plugins/module_utils/rds.py at ln58 and ln72 there's exception messages that refer to module_utils/aws/rds.py, and in plugins/module_utils/core.py, plugins/module_utils/rds.py, plugins/module_utils/batch.py comments that refer to ansible.module_utils.aws
can you please update those? Otherwise looks good.
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
Jun 18, 2020
* Remove legacy files in plugins/module_utils/aws * ci_complete * Clean up remaining instances of module_utils[./]aws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow-up to #26; once ansible-collections/community.aws#23 is merged this should be able to pass CI.
ISSUE TYPE
COMPONENT NAME
module_utils