Backport: rds module_util - support IAM roles #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing/removing IAM roles (ansible-collections#714) rds module_util - fix check_mode and idempotence bugs and support adding/removing IAM roles SUMMARY Add waiter for promoting read replica to fix idempotence bug in community.aws integration testing Support modifying IAM roles to a db instance for ansible-collections/community.aws#1002 Add necessary waiters for both adding and removing an IAM role compare and ensure iam_roles methods for idempotency unit & integration tests for coverage (integration tests in community.aws PR) ISSUE TYPE Feature Pull Request COMPONENT NAME module_util/rds community.aws.rds_instance ADDITIONAL INFORMATION Refs: (adding role) https://awscli.amazonaws.com/v2/documentation/api/latest/reference/rds/add-role-to-db-instance.html (removing role) https://awscli.amazonaws.com/v2/documentation/api/latest/reference/rds/remove-role-from-db-instance.html (waiters) https://awscli.amazonaws.com/v2/documentation/api/latest/reference/rds/describe-db-instances.html Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 00c752e)
ansibullbot
added
community_review
feature
markuman
approved these changes
Apr 12, 2022
|
recheck |
|
recheck |
alinabuzachis
approved these changes
Apr 13, 2022
jatorcasso
added
mergeit
|
regate |
|
regate |
softwarefactory-project-zuul
bot
merged commit ec370cd
into
ansible-collections:stable-3
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ctions#771) add `TargetTrackingScaling` as a scaling policy option SUMMARY Add TargetTrackingScaling as an EC2 scaling option. Fixes: ansible-collections#544 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_scaling_policy.py Reviewed-by: Jill R <None> Reviewed-by: James McClune <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ctions#771) add `TargetTrackingScaling` as a scaling policy option SUMMARY Add TargetTrackingScaling as an EC2 scaling option. Fixes: ansible-collections#544 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_scaling_policy.py Reviewed-by: Jill R <None> Reviewed-by: James McClune <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ctions#771) add `TargetTrackingScaling` as a scaling policy option SUMMARY Add TargetTrackingScaling as an EC2 scaling option. Fixes: ansible-collections#544 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_scaling_policy.py Reviewed-by: Jill R <None> Reviewed-by: James McClune <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport #714
ISSUE TYPE
COMPONENT NAME
rds