Merge pull request #250 from Akasurde/sanity_fixes

sanity fixes for pylint test SUMMARY Signed-off-by: Abhijeet Kasurde [email protected] ISSUE TYPE Docs Pull Request COMPONENT NAME changelogs/fragments/sanity_fixes.yml tests/sanity/ignore-2.12.txt tests/unit/mock/loader.py Reviewed-by: Andrew Klychkov <[email protected]> Reviewed-by: None <None>
ansible-collections · Aug 16, 2021 · 01bccb0 · 01bccb0
2 parents ab9eaf2 + 249e64a
commit 01bccb0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/changelogs/fragments/sanity_fixes.yml b/changelogs/fragments/sanity_fixes.yml
@@ -0,0 +1,3 @@
+---
+trivial:
+- sanity fixes for pylint test.
diff --git a/tests/sanity/ignore-2.12.txt b/tests/sanity/ignore-2.12.txt
@@ -1,4 +1,4 @@
-plugins/modules/synchronize.py pylint:blacklisted-name
+plugins/modules/synchronize.py pylint:disallowed-name
 plugins/modules/synchronize.py use-argspec-type-path
 plugins/modules/synchronize.py validate-modules:doc-default-does-not-match-spec
 plugins/modules/synchronize.py validate-modules:nonexistent-parameter-documented

diff --git a/tests/unit/mock/loader.py b/tests/unit/mock/loader.py
@@ -46,8 +46,8 @@ def load_from_file(self, path, cache=True, unsafe=False):
 
     # TODO: the real _get_file_contents returns a bytestring, so we actually convert the
     #       unicode/text it's created with to utf-8
-    def _get_file_contents(self, path):
-        path = to_text(path)
+    def _get_file_contents(self, file_name):
+        path = to_text(file_name)
         if path in self._file_mapping:
             return (to_bytes(self._file_mapping[path]), False)
         else: