Firewalld fails to configure port forward

[paddatrapper]

SUMMARY

Firewalld port forwarding uses an incorrect keyword parameter. Downgrading to 1.2.0 fixes the issue

fatal: [XXX]: FAILED! => {"changed": false, "msg": "ERROR: Exception caught: queryForwardPort() got an unexpected keyword argument 'to_port'"}

ISSUE TYPE

• Bug Report

COMPONENT NAME

firewalld

ANSIBLE VERSION

ansible 2.10.8
  config file = /home/kyle/.ansible.cfg
  configured module search path = ['/home/kyle/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.9.2 (default, Feb 28 2021, 17:03:44) [GCC 10.2.1 20210110]

COLLECTION VERSION

# /home/kyle/.ansible/collections/ansible_collections
Collection    Version
------------- -------
ansible.posix 1.3.0  

# /usr/lib/python3/dist-packages/ansible_collections
Collection    Version
------------- -------
ansible.posix 1.1.1

CONFIGURATION

ANSIBLE_SSH_ARGS(/home/kyle/.ansible.cfg) = -C -o ControlMaster=auto -o ControlPersist=60s -o StrictHostKeyChecking=no
ANSIBLE_SSH_CONTROL_PATH(/home/kyle/.ansible.cfg) = %(directory)s/%%C
DEFAULT_HOST_LIST(/home/kyle/.ansible.cfg) = ['/home/kyle/.ansible/hosts']
DEFAULT_MANAGED_STR(/home/kyle/.ansible.cfg) = Managed by ansible. All changes will be overwritten
INTERPRETER_PYTHON(/home/kyle/.ansible.cfg) = /usr/bin/python3
RETRY_FILES_ENABLED(/home/kyle/.ansible.cfg) = False

OS / ENVIRONMENT

Client: Debian unstable
Target: Debian Buster

STEPS TO REPRODUCE

- name: forward traffic to container                                                                                                                                                           
  ansible.posix.firewalld:                                                                                                                                                                     
    zone: external                                                                                                                                                                             
    port_forward:        
      - port: 51820
        proto: udp      
        toaddr: "10.0.3.12"
        toport: 51820                                                                          
    state: enabled
    immediate: yes

EXPECTED RESULTS

The task should succeed and add a port forwarding firewall rule

ACTUAL RESULTS

fatal: [XXX]: FAILED! => {"changed": false, "msg": "ERROR: Exception caught: queryForwardPort() got an unexpected keyword argument 'to_port'"}

[Akasurde]

@paddatrapper Thanks for reporting this. Could you please provide the version of python3-firewall and firewalld?

I am not able to reproduce this on the following settings

I am able to reproduce this -

# cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
# dpkg -l | grep firewall
rc  firewalld                     0.6.3-5                      all          dynamically managed firewall with support for network zones
ii  python3-firewall              0.8.2-1~bpo10+1              all          Python3 bindings for firewalld
...
(Pdb) fw_settings.queryForwardPort(port='51820', protocol='UDP', to_port='51820', to_addr='10.0.3.12')
False
...

[paddatrapper]

# cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
# dpkg -l | grep firewall
ii  firewalld                             0.8.2-1~bpo10+1               all          dynamically managed firewall with support for network zones
ii  python3-firewall                      0.8.2-1~bpo10+1               all          Python3 bindings for firewalld

[Akasurde]

@paddatrapper I am able to reproduce this on my setup. Could you please check if PR #248 works for you and let me know? Thanks.

[paddatrapper]

Yup, that works for me. Thanks!