Inform synchronize module about community.docker collection #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akasurde
requested changes
Mar 1, 2021
|
CI failures are known. PR ansible/ansible#73609 will resolve the error. |
|
👍 for this change! |
tadeboro
force-pushed
the
teach-synchronize-about-community-docker
branch
from
e625fbf
to
6cfde26
Compare
|
I added a changelog fragment. My plan was to add it once I know things are green, but I guess this might take a while to become reality ;) |
felixfontein
reviewed
Mar 1, 2021
Comment on lines
3
to
4
| - synchronize - add community.docker.docker to the list of supported | ||
| transports (https://github.com/ansible-collections/ansible.posix/issues/132) |
There was a problem hiding this comment.
Suggested change
| - synchronize - add community.docker.docker to the list of supported | |
| transports (https://github.com/ansible-collections/ansible.posix/issues/132) | |
| - synchronize - add ``community.docker.docker`` to the list of supported | |
| transports (https://github.com/ansible-collections/ansible.posix/issues/132). |
tadeboro
force-pushed
the
teach-synchronize-about-community-docker
branch
from
6cfde26
to
a5e4601
Compare
felixfontein
approved these changes
Mar 2, 2021
|
recheck |
felixfontein
reviewed
Mar 2, 2021
tadeboro
force-pushed
the
teach-synchronize-about-community-docker
branch
from
a5e4601
to
5814ce1
Compare
felixfontein
approved these changes
Mar 5, 2021
|
recheck |
The synchronize action plugin has a built-in list of connection plugins that it knows how to handle. One of those connection plugins is the docker connection plugin. And because the docker content has been moved around quite a lot, the docker connection plugin has quite a few names: - docker in Ansible 2.9, - community.general.docker for community.general < 2.0.0, and - community.docker.docker since a few months ago. And while the synchronize module already knew about the first two names, the last one was still missing. This commit fixes that omission and adds a third name into the mix.
tadeboro
force-pushed
the
teach-synchronize-about-community-docker
branch
from
5814ce1
to
98c86c5
Compare
|
the tests passed now |
|
after this merged, i can release the collection next week (if nobody disagrees) |
maxamillion
added
the
gate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The synchronize action plugin has a built-in list of connection plugins that it knows how to handle.
One of those connection plugins is the docker connection plugin. And because the docker content has been moved around quite a lot, the docker connection plugin has quite a few names:
And while the synchronize module already knew about the first two names, the last one was still missing. This commit fixes that omission and adds a third name into the mix.
Fixes #132
ISSUE TYPE
COMPONENT NAME
synchronize