-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible.posix.mount: add absent_from_fstab option #166
ansible.posix.mount: add absent_from_fstab option #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Can you please also add changelog?
Co-authored-by: Amin Vakil <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 22.57% 22.57%
=======================================
Files 40 40
Lines 3800 3800
Branches 759 759
=======================================
Hits 858 858
Misses 2797 2797
Partials 145 145 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Closing and re-opening for CI trigger. |
Build failed (gate pipeline). For information on how to proceed, see ✔️ ansible-changelog-fragment SUCCESS in 17s |
Closing and reopening to confirm merge process |
Build succeeded. ✔️ ansible-changelog-fragment SUCCESS in 16s |
Build succeeded (gate pipeline). ✔️ ansible-changelog-fragment SUCCESS in 16s |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ansible.posix](https://togithub.com/ansible-collections/ansible.posix) | galaxy-collection | minor | `1.4.0` -> `1.5.1` | --- ### Release Notes <details> <summary>ansible-collections/ansible.posix</summary> ### [`v1.5.1`](https://togithub.com/ansible-collections/ansible.posix/blob/HEAD/CHANGELOG.rst#v151) [Compare Source](https://togithub.com/ansible-collections/ansible.posix/compare/1.5.0...1.5.1) \====== ## Minor Changes - mount - Add `absent_from_fstab` state ([https://github.com/ansible-collections/ansible.posix/pull/166](https://togithub.com/ansible-collections/ansible.posix/pull/166)). - mount - Add `ephemeral` value for the `state` parameter, that allows to mount a filesystem without altering the `fstab` file ([https://github.com/ansible-collections/ansible.posix/pull/267](https://togithub.com/ansible-collections/ansible.posix/pull/267)). - r4e_rpm_ostree - new module for validating package state on RHEL for Edge - rhel_facts - new facts module to handle RHEL specific facts - rhel_rpm_ostree - new module to handle RHEL rpm-ostree specific package management functionality - rpm_ostree_upgrade - new module to automate rpm-ostree upgrades - rpm_ostree_upgrade - new module to manage upgrades for rpm-ostree based systems ## Bugfixes - Removed contentious terminology to match reference documentation in profile_tasks. - firewall - Fixed to output a more complete missing library message. - synchronize - Fixed hosts involved in rsync require the same password ### [`v1.5.0`](https://togithub.com/ansible-collections/ansible.posix/compare/1.4.0...1.5.0) [Compare Source](https://togithub.com/ansible-collections/ansible.posix/compare/1.4.0...1.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDYuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwNi4wIn0=--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
SUMMARY
Add absent_from_fstab option to remove the entry from fstab, but not unmount or delete the folder. Ideally this would have been the behavior of absent (as to mirror the behavior of present), but for backward compatibility I added a new verbose state
ISSUE TYPE
COMPONENT NAME
mount
ADDITIONAL INFORMATION
Sometimes you may not want to delete the mountpoint (e.g. if it is not currently mounted and data is in the directory, the current behavior will simply error).