Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible.posix.mount: add absent_from_fstab option #166

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

dkjii-g
Copy link
Contributor

@dkjii-g dkjii-g commented Apr 2, 2021

SUMMARY

Add absent_from_fstab option to remove the entry from fstab, but not unmount or delete the folder. Ideally this would have been the behavior of absent (as to mirror the behavior of present), but for backward compatibility I added a new verbose state

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mount

ADDITIONAL INFORMATION

Sometimes you may not want to delete the mountpoint (e.g. if it is not currently mounted and data is in the directory, the current behavior will simply error).

Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Can you please also add changelog?

plugins/modules/mount.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #166 (ecd5ad5) into main (ecd5ad5) will not change coverage.
The diff coverage is n/a.

❗ Current head ecd5ad5 differs from pull request most recent head 553b0ea. Consider uploading reports for the commit 553b0ea to get more accurate results

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   22.57%   22.57%           
=======================================
  Files          40       40           
  Lines        3800     3800           
  Branches      759      759           
=======================================
  Hits          858      858           
  Misses       2797     2797           
  Partials      145      145           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Akasurde
Copy link
Member

Closing and re-opening for CI trigger.

@Akasurde Akasurde closed this May 27, 2021
@Akasurde Akasurde reopened this May 27, 2021
@maxamillion maxamillion added gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate") mergeit Gate PR in Zuul CI and removed gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate") labels Nov 21, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

✔️ ansible-changelog-fragment SUCCESS in 17s
ansible-test-sanity-docker-devel FAILURE in 6m 55s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 6m 57s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 21s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 7m 52s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 08s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 19s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 04s
ansible-test-units-posix-python39 FAILURE in 6m 03s
ansible-test-units-posix-python310 FAILURE in 5m 13s
✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 3m 12s

@saito-hideki
Copy link
Collaborator

Closing and reopening to confirm merge process

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-changelog-fragment SUCCESS in 16s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 16s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 6m 42s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 54s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 9m 02s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 34s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 41s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 05s
✔️ ansible-test-units-posix-python39 SUCCESS in 5m 18s
✔️ ansible-test-units-posix-python310 SUCCESS in 5m 13s
✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 3m 18s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-changelog-fragment SUCCESS in 16s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 15s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 10s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 33s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 8m 21s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 54s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 44s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 20s
✔️ ansible-test-units-posix-python39 SUCCESS in 5m 14s
✔️ ansible-test-units-posix-python310 SUCCESS in 5m 18s
✔️ ansible-galaxy-importer SUCCESS in 3m 53s
✔️ build-ansible-collection SUCCESS in 3m 26s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6b7dc6e into ansible-collections:main Dec 15, 2022
coolguy1771 referenced this pull request in coolguy1771/home-ops Jan 21, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[ansible.posix](https://togithub.com/ansible-collections/ansible.posix)
| galaxy-collection | minor | `1.4.0` -> `1.5.1` |

---

### Release Notes

<details>
<summary>ansible-collections/ansible.posix</summary>

###
[`v1.5.1`](https://togithub.com/ansible-collections/ansible.posix/blob/HEAD/CHANGELOG.rst#v151)

[Compare
Source](https://togithub.com/ansible-collections/ansible.posix/compare/1.5.0...1.5.1)

\======

## Minor Changes

- mount - Add `absent_from_fstab` state
([https://github.com/ansible-collections/ansible.posix/pull/166](https://togithub.com/ansible-collections/ansible.posix/pull/166)).
- mount - Add `ephemeral` value for the `state` parameter, that allows
to mount a filesystem without altering the `fstab` file
([https://github.com/ansible-collections/ansible.posix/pull/267](https://togithub.com/ansible-collections/ansible.posix/pull/267)).
- r4e_rpm_ostree - new module for validating package state on RHEL for
Edge
-   rhel_facts - new facts module to handle RHEL specific facts
- rhel_rpm_ostree - new module to handle RHEL rpm-ostree specific
package management functionality
-   rpm_ostree_upgrade - new module to automate rpm-ostree upgrades
- rpm_ostree_upgrade - new module to manage upgrades for rpm-ostree
based systems

## Bugfixes

- Removed contentious terminology to match reference documentation in
profile_tasks.
-   firewall - Fixed to output a more complete missing library message.
- synchronize - Fixed hosts involved in rsync require the same password

###
[`v1.5.0`](https://togithub.com/ansible-collections/ansible.posix/compare/1.4.0...1.5.0)

[Compare
Source](https://togithub.com/ansible-collections/ansible.posix/compare/1.4.0...1.5.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDYuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwNi4wIn0=-->

Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Gate PR in Zuul CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants