Add UserAssigned Identity to aks module #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
reviewed
May 7, 2024
plugins/modules/azure_rm_aks.py
Outdated
| @@ -590,6 +611,9 @@ | |||
| provisioning_state: Succeeded | |||
| service_principal_profile: | |||
| client_id: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx | |||
| identity: | |||
| "type": "UserAssigned", | |||
There was a problem hiding this comment.
Suggested change
| "type": "UserAssigned", | |
| "type": "UserAssigned" |
plugins/modules/azure_rm_aks.py
Outdated
| @@ -938,6 +985,8 @@ def __init__(self): | |||
| self.node_resource_group = None | |||
| self.pod_identity_profile = None | |||
|
|
|||
| mutually_exclusive = [('identity','service_principal')] | |||
There was a problem hiding this comment.
missing whitespace after ','
Suggested change
| mutually_exclusive = [('identity','service_principal')] | |
| mutually_exclusive = [('identity', 'service_principal')] |
plugins/modules/azure_rm_aks.py
Outdated
| @@ -1387,6 +1450,35 @@ def create_addon_profile_instance(self, addon): | |||
| return result | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
too many blank!
Suggested change
plugins/modules/azure_rm_aks.py
Outdated
| identity=dict( | ||
| type='dict', | ||
| options=managed_identity_spec, | ||
| required_if = [ |
There was a problem hiding this comment.
unexpected spaces around keyword / parameter equals
Suggested change
| required_if = [ | |
| required_if=[ |
Fred-sun
added
medium_priority
Adds the ability to assign User Assigned Identity to the Azure Kubernetes Service.
|
Thanks for the feedback. I will be sure to run sanity tests from now on. |
|
@p3ck No further questions, I will push for merger. Thank you! |
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds the ability to assign User Assigned Identity to the Azure Kubernetes Service.
ISSUE TYPE
COMPONENT NAME
azure_rm_aks
ADDITIONAL INFORMATION
Currently the aks module only supports a service_principal or System Assigned identity. This adds the ability to assign a User Assigned Identity to the cluster.
Integration tests have been updated to validate this feature.