Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_manageddisk_info - Add time_created in return to module #1638

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

valkiriaaquatica
Copy link
Contributor

SUMMARY

Now it returns the time_created that is the time when the disk was created. I found this usefull because is the more "accurate" way of checking when a virtual machine was first deployed as normally it is attached to a disk.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_manageddisk_info

ADDITIONAL INFORMATION

The module didn't return the first date when the disk was created. This info can be really usefull to know when the disk was createed and so the virtual machine (not 100% sure but really accurate)

Return example before the change:

{
  "ansible_info": {
    "azure_managed_disk": [
      {
        "create_option": "",
        "disk_size_gb": 1,
        "id": "xxxx",
        "location": "xxxx",
        "managed_by": "xxxx",
        "managed_by_extended": null,
        "max_shares": null,
        "name": "xxxx",
        "os_type": "xxx",
        "source_uri": null,
        "storage_account_type": "xxxx",
        "tags": null,
        "zone": ""
      }
    ]
  },
  "changed": false
}

Return example after the change

{
  "ansible_info": {
    "azure_managed_disk": [
      {
        "create_option": "xx",
        "disk_size_gb": 1,
        "id": "xxxx2",
        "location": "xxxx",
        "managed_by": "xxxx",
        "managed_by_extended": null,
        "max_shares": null,
        "name": "xxxx",
        "os_type": "xxxx",
        "source_uri": null,
        "storage_account_type": "xxxx",
        "tags": null,
        "time_created": "2018-01-01T11:08:15.338248+00:00",
        "zone": ""
      }
    ]
  },
  "changed": false
}

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority new_feature New feature requirments labels Jul 22, 2024
@xuzhang3 xuzhang3 changed the title Add time_created in return to module azure_rm_manageddisk_info - Add time_created in return to module Jul 22, 2024
@xuzhang3 xuzhang3 merged commit d2fda00 into ansible-collections:dev Jul 22, 2024
@valkiriaaquatica valkiriaaquatica deleted the patch-2 branch July 22, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants