Fix SDK call to use Configuration class #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> > Until now, begin_create_or_update function was called with values directly which caused to failure due to unexpected format, str instead of dict. > Changes to use Configuration class for the parameter's value Signed-off-by: hyaish <[email protected]>
|
@Fred-sun @xuzhang3 can you please review this? |
nirarg
approved these changes
Aug 12, 2024
xuzhang3
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, begin_create_or_update function was called with values directly which caused failure due to unexpected format, str instead of dict.
Changes to use Configuration class for the parameter's value
SUMMARY
Wrapped value and source parameters with Configuration class in begin_create_or_update function
ISSUE TYPE
COMPONENT NAME
azure_rm_postgresqlconfiguration
ADDITIONAL INFORMATION