-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally call MSI auth when interacting with keyvault #356
Merged
haiyuazhang
merged 7 commits into
ansible-collections:dev
from
opfpqgoon:fix_keyvault_always_msi
Mar 4, 2021
Merged
Conditionally call MSI auth when interacting with keyvault #356
haiyuazhang
merged 7 commits into
ansible-collections:dev
from
opfpqgoon:fix_keyvault_always_msi
Mar 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opfpqgoon
changed the title
Conditionally call MSI auth
Conditionally call MSI auth when interacting with keyvault
Dec 8, 2020
|
@opfpqgoon Can I make some updates to some of the Sanity errors above? Thank you very much! |
Please do!
… On Feb 7, 2021, at 03:51, Fred-sun ***@***.***> wrote:
@opfpqgoon Can I make some updates to some of the Sanity errors above? Thank you very much!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Fred-sun
added
ready_for_review
The PR has been modified and can be reviewed and merged
and removed
work in
In trying to solve, or in working with contributors
labels
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
MSI auth shouldn't be used unless the module specifically calls for it. Currently MSI will be tried anytime the modules are called from an Azure VM, even if the MSI doesn't (and shouldn't) have access to the keyvault.
ISSUE TYPE
COMPONENT NAME
azure_rm_keyvaultsecret
azure_rm_keyvaultsecret_info
azure_rm_keyvaultkey
azure_rm_keyvaultkey_info
ADDITIONAL INFORMATION