change class name of azure_rm_aduser #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiyuazhang
added a commit
that referenced
this pull request
May 12, 2021
This reverts commit 24b08f7.
haiyuazhang
added a commit
that referenced
this pull request
May 13, 2021
* check python version * add new change * ad new * for test * check python version * update ado.sh * add new change * add new change * Perfect the ado.sh * fix sanity 2.7 error * delete virtual env set * fix small * revert virtual env change * fixing update account_enabled bug in azure_rm_aduser.py (#524) * fixing ad related auth issue when using service pricinpal. (#525) * change class name of azure_rm_aduser (#526) * class are worngly named. fixed. * fixing sanity errors. Co-authored-by: haiyuan_zhang <[email protected]>
haiyuazhang
added a commit
that referenced
this pull request
May 28, 2021
* fixing update account_enabled bug in azure_rm_aduser.py (#524) * fixing ad related auth issue when using service pricinpal. (#525) * change class name of azure_rm_aduser (#526) * class are worngly named. fixed. * fixing sanity errors. * Add azure_rm_ipgroup module * Upgraded version_added * Removed log_mode and log_path * Addressed review comments Co-authored-by: haiyuan_zhang <[email protected]> Co-authored-by: Fred-sun <[email protected]>
haiyuazhang
pushed a commit
that referenced
this pull request
May 28, 2021
* Added new module for proximity placement group * fixing update account_enabled bug in azure_rm_aduser.py (#524) * fixing ad related auth issue when using service pricinpal. (#525) * change class name of azure_rm_aduser (#526) * class are worngly named. fixed. * fixing sanity errors. * updated version_added and fixed minor tags related issue * Removed log_mode and log_path * Addressed review comments Co-authored-by: Fred-sun <[email protected]>
haiyuazhang
pushed a commit
that referenced
this pull request
May 28, 2021
* Added new module for Virtual network links * Updated version_added * documentation updates based on sanity tests * Update tests/integration/targets/azure_rm_privatednszone_vnetlink/aliases Co-authored-by: Fred-sun <[email protected]> * Update tests/sanity/ignore-2.10.txt Co-authored-by: Fred-sun <[email protected]> * Update tests/sanity/ignore-2.11.txt Co-authored-by: Fred-sun <[email protected]> * Applying suggested changes * fixing update account_enabled bug in azure_rm_aduser.py (#524) * fixing ad related auth issue when using service pricinpal. (#525) * change class name of azure_rm_aduser (#526) * class are worngly named. fixed. * fixing sanity errors. * upgraded version_added and fixed minor error related to tags updation * Update plugins/modules/azure_rm_privatednszonelink.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_privatednszonelink.py Co-authored-by: Fred-sun <[email protected]> * Removed log_mode and log_path * Update tests/integration/targets/azure_rm_privatednszonelink/tasks/main.yml Co-authored-by: Fred-sun <[email protected]> Co-authored-by: Fred-sun <[email protected]>
xuzhang3
pushed a commit
that referenced
this pull request
Jun 24, 2021
* notification hub changes * integration changes * new changes * remaining changes * remaining changes * address changes * address changes * minor change * address comments * fixing update account_enabled bug in azure_rm_aduser.py (#524) * fixing ad related auth issue when using service pricinpal. (#525) * change class name of azure_rm_aduser (#526) * class are worngly named. fixed. * fixing sanity errors. * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * update version Co-authored-by: Praveen Ghuge <[email protected]> Co-authored-by: haiyuan_zhang <[email protected]> Co-authored-by: Praveen Ghuge <[email protected]>
xuzhang3
pushed a commit
that referenced
this pull request
Jun 24, 2021
* first commit * fix file * new changes * working create/update/delete/get * change username * minor changes * Fix sanity issues * Improve integration test * remove return * address changes * changes addressed * address changes * address changes * small change * fixing update account_enabled bug in azure_rm_aduser.py (#524) * fixing ad related auth issue when using service pricinpal. (#525) * change class name of azure_rm_aduser (#526) * class are worngly named. fixed. * fixing sanity errors. * address cahnges * new changes * new changes * addrss changes * address changes * address changes * address changes * merge upstream changes * address changes * update version Co-authored-by: root <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Praveen Ghuge <[email protected]> Co-authored-by: Praveen Ghuge <[email protected]> Co-authored-by: Karl Dasan <[email protected]> Co-authored-by: haiyuan_zhang <[email protected]>
xuzhang3
pushed a commit
that referenced
this pull request
Aug 6, 2021
* initial commit * add ddos protection plan operations * enhance create flow * enhance operations * enhance get and delete operations * address sanity checks * add integration tests * add log parameters and aliases * rename module for consistency * update pr-pipeline for consistency * fixing update account_enabled bug in azure_rm_aduser.py (#524) * fixing ad related auth issue when using service pricinpal. (#525) * change class name of azure_rm_aduser (#526) * class are worngly named. fixed. * fixing sanity errors. * updating ignore text * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update tests/integration/targets/azure_rm_ddosprotectionplan/tasks/main.yml Co-authored-by: Fred-sun <[email protected]> * Update tests/integration/targets/azure_rm_ddosprotectionplan/tasks/main.yml Co-authored-by: Fred-sun <[email protected]> * Update main.yml * delete ignores * remove ignores * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_ddosprotectionplan_info.py Co-authored-by: Fred-sun <[email protected]> Co-authored-by: haiyuan_zhang <[email protected]> Co-authored-by: Fred-sun <[email protected]>
Fred-sun
pushed a commit
to Fred-sun/ansible_collections_azure
that referenced
this pull request
Aug 11, 2021
* notification hub changes * integration changes * new changes * remaining changes * remaining changes * address changes * address changes * minor change * address comments * fixing update account_enabled bug in azure_rm_aduser.py (ansible-collections#524) * fixing ad related auth issue when using service pricinpal. (ansible-collections#525) * change class name of azure_rm_aduser (ansible-collections#526) * class are worngly named. fixed. * fixing sanity errors. * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * address changes * update version Co-authored-by: Praveen Ghuge <[email protected]> Co-authored-by: haiyuan_zhang <[email protected]> Co-authored-by: Praveen Ghuge <[email protected]>
Fred-sun
pushed a commit
to Fred-sun/ansible_collections_azure
that referenced
this pull request
Aug 11, 2021
* first commit * fix file * new changes * working create/update/delete/get * change username * minor changes * Fix sanity issues * Improve integration test * remove return * address changes * changes addressed * address changes * address changes * small change * fixing update account_enabled bug in azure_rm_aduser.py (ansible-collections#524) * fixing ad related auth issue when using service pricinpal. (ansible-collections#525) * change class name of azure_rm_aduser (ansible-collections#526) * class are worngly named. fixed. * fixing sanity errors. * address cahnges * new changes * new changes * addrss changes * address changes * address changes * address changes * merge upstream changes * address changes * update version Co-authored-by: root <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Praveen Ghuge <[email protected]> Co-authored-by: Praveen Ghuge <[email protected]> Co-authored-by: Karl Dasan <[email protected]> Co-authored-by: haiyuan_zhang <[email protected]>
Fred-sun
added a commit
to Fred-sun/ansible_collections_azure
that referenced
this pull request
Aug 11, 2021
* initial commit * add ddos protection plan operations * enhance create flow * enhance operations * enhance get and delete operations * address sanity checks * add integration tests * add log parameters and aliases * rename module for consistency * update pr-pipeline for consistency * fixing update account_enabled bug in azure_rm_aduser.py (ansible-collections#524) * fixing ad related auth issue when using service pricinpal. (ansible-collections#525) * change class name of azure_rm_aduser (ansible-collections#526) * class are worngly named. fixed. * fixing sanity errors. * updating ignore text * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update tests/integration/targets/azure_rm_ddosprotectionplan/tasks/main.yml Co-authored-by: Fred-sun <[email protected]> * Update tests/integration/targets/azure_rm_ddosprotectionplan/tasks/main.yml Co-authored-by: Fred-sun <[email protected]> * Update main.yml * delete ignores * remove ignores * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_ddosprotectionplan_info.py Co-authored-by: Fred-sun <[email protected]> Co-authored-by: haiyuan_zhang <[email protected]> Co-authored-by: Fred-sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
change the class name for azure_rm_aduser to AzureRMADUser
ISSUE TYPE
COMPONENT NAME
azure_rm_aduser.py
ADDITIONAL INFORMATION
None