Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Metadata support to azure_rm_dnsrecordset.py #589

Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 3, 2021

SUMMARY

Added support for attaching metadata to dnsrecordsets.

Fixes #470

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_dnsrecordset.py
azure_rm_dnsrecordset_info.py

ADDITIONAL INFORMATION

DNS recordset APIs does not support tags attribute, instead it has 'metadata' argument that needs to be used for attaching metadata information to record set.
https://docs.microsoft.com/en-us/rest/api/dns/record-sets/create-or-update

@Fred-sun
Copy link
Collaborator

Fred-sun commented Aug 5, 2021

@techcon65 Thank you for contributing this feature. Can you add a use case for it? Thank you very much!

@Fred-sun
Copy link
Collaborator

Fred-sun commented Aug 5, 2021

@techcon65 Please delete the statement in ignore (ignore-2.9.txt,ignore-2.10.txt,ignore-2.11.txt,ignore-2.12.txt). Thank you very much!

ERROR: 
tests/sanity/ignore-2.10.txt:55:1: A100: Ignoring 'doc-missing-type' on 'plugins/modules/azure_rm_dnsrecordset.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:56:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_dnsrecordset.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:57:1: A100: Ignoring 'doc-elements-mismatch' on 'plugins/modules/azure_rm_dnsrecordset.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:59:1: A100: Ignoring 'return-syntax-error' on 'plugins/modules/azure_rm_dnsrecordset.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:60:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_dnsrecordset_info.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:61:1: A100: Ignoring 'return-syntax-error' on 'plugins/modules/azure_rm_dnsrecordset_info.py' is unnecessary

@Fred-sun Fred-sun added medium_priority Medium priority new_feature New feature requirments work in In trying to solve, or in working with contributors labels Aug 5, 2021
@ghost
Copy link
Author

ghost commented Aug 9, 2021

@techcon65 Please delete the statement in ignore (ignore-2.9.txt,ignore-2.10.txt,ignore-2.11.txt,ignore-2.12.txt). Thank you very much!

ERROR: 
tests/sanity/ignore-2.10.txt:55:1: A100: Ignoring 'doc-missing-type' on 'plugins/modules/azure_rm_dnsrecordset.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:56:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_dnsrecordset.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:57:1: A100: Ignoring 'doc-elements-mismatch' on 'plugins/modules/azure_rm_dnsrecordset.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:59:1: A100: Ignoring 'return-syntax-error' on 'plugins/modules/azure_rm_dnsrecordset.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:60:1: A100: Ignoring 'parameter-type-not-in-doc' on 'plugins/modules/azure_rm_dnsrecordset_info.py' is unnecessary
ERROR: tests/sanity/ignore-2.10.txt:61:1: A100: Ignoring 'return-syntax-error' on 'plugins/modules/azure_rm_dnsrecordset_info.py' is unnecessary

@Fred-sun updated the files. Thank you very much!

@ghost
Copy link
Author

ghost commented Aug 9, 2021

@techcon65 Thank you for contributing this feature. Can you add a use case for it? Thank you very much!

Added the example, Thank you!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Aug 9, 2021
@Fred-sun
Copy link
Collaborator

Fred-sun commented Dec 7, 2021

@ghost It would be great if “tests/sanity/ignore-2.13.txt” could be updated as well! Thank you very much!

@Fred-sun Fred-sun removed the ready_for_review The PR has been modified and can be reviewed and merged label Dec 8, 2021
@Fred-sun Fred-sun added the ready_for_review The PR has been modified and can be reviewed and merged label Dec 8, 2021
@xuzhang3 xuzhang3 merged commit 4abeead into ansible-collections:dev Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_dnsrecordset doesn't apply metadata tags for records
3 participants