Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure_rm_securitygroup doc #640

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

nbr23
Copy link
Contributor

@nbr23 nbr23 commented Sep 26, 2021

SUMMARY

Clarify documentation for source/destination prefix for NSG rules

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
  • azure_rm_securitygroup
ADDITIONAL INFORMATION

NSG rules parameters destination_address_prefix and source_address_prefix only accept default tags (*, Internet, etc) as strings, not as elements of a list. This appears to be by design as only one default tag prefix can be specified.

This documentation update reflects this restriction, raised in #639

@Fred-sun Fred-sun added documentation-pr Improvements or additions to documentation medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged labels Sep 27, 2021
@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 closed this Oct 19, 2021
@xuzhang3 xuzhang3 reopened this Oct 19, 2021
@xuzhang3 xuzhang3 merged commit 75bc266 into ansible-collections:dev Oct 19, 2021
@nbr23 nbr23 deleted the nsg_doc branch October 19, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-pr Improvements or additions to documentation medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants