Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azure_rm_galleryimage.py to allow Hyper-V Generation #647

Merged
merged 3 commits into from Mar 11, 2022
Merged

Update azure_rm_galleryimage.py to allow Hyper-V Generation #647

merged 3 commits into from Mar 11, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2021

Added Hyper V Generation

SUMMARY

Added Hyper-V Generation which allows different versions of Gallery Image - if there is any syntax stuff I need to change please let me know

Fixes #646

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Hyper-V Generation to allow v2 which allows your Virtual Machines to boot faster when using this boot option

ADDITIONAL INFORMATION
-   name: Create or update gallery image
    azure_rm_galleryimage:
        hypervgeneration: V2
        resource_group: '{{ clientname }}-rg'
        gallery_name: '{{ clientname }}avdimages'
        name: Windows10MSPrimary-Gold
        location: '{{ location }}'
        os_type: windows
        os_state: generalized
        identifier:
            publisher: '{{ clientname }}Publisher'
            offer: '{{ clientname }}Offer'
            sku: '{{ clientname }}SKU'
        disallowed:
            disk_types: Standard_LRS
        recommended:
            memory:
                max: 64
                min: 8
            v_cpus:
                max: 24
                min: 4

Update azure_rm_galleryimage.py
8402383 
Added Hyper V Generation
@Fred-sun Fred-sun requested a review from xuzhang3 October 8, 2021 09:30
@Fred-sun Fred-sun added medium_priority Medium priority new_feature New feature requirments work in In trying to solve, or in working with contributors labels Oct 8, 2021
@Fred-sun
Copy link
Collaborator

Kindly ping!

Fred-sun
Fred-sun reviewed Nov 23, 2021
View reviewed changes
plugins/modules/azure_rm_galleryimage.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_galleryimage.py Outdated Show resolved Hide resolved
@Fred-sun
Copy link
Collaborator

small change request!

@Fred-sun
Copy link
Collaborator

Kindly ping!

ghost
ghost commented Jan 2, 2022
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jan 6, 2022
@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit 15d17ab into ansible-collections:dev Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VM generation not supported in azure.azcollection.azure_rm_galleryimage
2 participants
@Fred-sun @xuzhang3