Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct doc for azure_rm_appgateway state #674

Merged
merged 4 commits into from
Dec 7, 2021

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Nov 6, 2021

SUMMARY

This PR corrects the documentation for azure_rm_appgateway, where the state property incorrectly mentions "public IP".

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_appgateway

ADDITIONAL INFORMATION

See also: https://docs.ansible.com/ansible/latest/collections/azure/azcollection/azure_rm_appgateway_module.html#parameter-state.

@l3ender
Copy link
Contributor Author

l3ender commented Nov 6, 2021

@Fred-sun Please review...thank you!

@Fred-sun
Copy link
Collaborator

Fred-sun commented Nov 8, 2021

@l3ender Thank you for your contribution. We will complete the review and push forward the merger as soon as possible.

@Fred-sun Fred-sun added documentation-pr Improvements or additions to documentation medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged labels Nov 8, 2021
@l3ender
Copy link
Contributor Author

l3ender commented Dec 6, 2021

Hello, wondering if there is anything else I can do for this PR? It is a simple doc fix.

Thank you!

@Fred-sun
Copy link
Collaborator

Fred-sun commented Dec 7, 2021

@l3ender We are reviewing and will push forward the merger as soon as possible. Thank you very much!

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Dec 7, 2021

LGTM

@xuzhang3 xuzhang3 merged commit 7db4bd1 into ansible-collections:dev Dec 7, 2021
@xuzhang3 xuzhang3 deleted the appgw-doc branch December 7, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-pr Improvements or additions to documentation medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants