Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct cosmosdb info module when loading by resource group #709

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Dec 14, 2021

SUMMARY

This PR corrects the info module for cosmosdb to correctly filter by resource group.

Fixes #708

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_cosmosdbaccount_info

ADDITIONAL INFORMATION

The following playbook can be used to validate the test cases for the azure_rm_cosmosdbaccount_info module.

---
- name: "Playbook for testing."
  hosts: "localhost"
  connection: "local"
  gather_facts: false
  vars:
    resource_group: "automated-testing"
    resource_group_secondary: "automated-testing-secondary"
  collections:
    - azure.azcollection

  tasks:
    - name: "Include tests"
      include_tasks: "tests/integration/targets/azure_rm_cosmosdbaccount/tasks/main.yml"

@l3ender
Copy link
Contributor Author

l3ender commented Dec 14, 2021

@Fred-sun A PR for a small bug I found in azure_rm_cosmosdbaccount_info module. Please review and advise--thank you!

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors labels Dec 16, 2021
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Dec 17, 2021
@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit 06afc0c into ansible-collections:dev Dec 20, 2021
@xuzhang3 xuzhang3 deleted the cosmos-info-load-by-rg branch December 20, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_cosmosdbaccount_info does not filter by resource_group
3 participants