Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.0] Remove deprecated module aliases #1256

Closed
1 task done
tremble opened this issue Jun 24, 2022 · 3 comments
Closed
1 task done

[5.0.0] Remove deprecated module aliases #1256

tremble opened this issue Jun 24, 2022 · 3 comments
Labels
bug This issue/PR relates to a bug has_pr module module needs_triage plugins plugin (any type)

Comments

@tremble
Copy link
Contributor

tremble commented Jun 24, 2022 •
edited
Loading

Summary

iam_cert and rds_snapshot aliases were slated for removal in 4.0.0

Do this as two PRs:

  • Bump the deprecation to 5.0.0 (backport to stable-4)
  • Remove the deprecations in 5.0.0

Issue Type

Bug Report

Component Name

iam_cert
rds_snapshot

Ansible Version

CI

Collection Versions

CI

AWS SDK versions

$ pip show boto boto3 botocore

Configuration

CI

OS / Environment

CI

Steps to Reproduce

Run sanity tests without ignore entries

Expected Results

No errors

Actual Results

2022-06-24 08:03:21.979896 | controller | ERROR: meta/runtime.yml:0:0: The deprecation removal_version ('4.0.0') must be after the current version (SemanticVersion('4.0.1-dev1')) for dictionary value @ data['plugin_routing']['modules']['iam_cert']['deprecation']['removal_version']. Got '4.0.0'
2022-06-24 08:03:21.979922 | controller | ERROR: meta/runtime.yml:0:0: The deprecation removal_version ('4.0.0') must be after the current version (SemanticVersion('4.0.1-dev1')) for dictionary value @ data['plugin_routing']['modules']['rds_snapshot']['deprecation']['removal_version']. Got '4.0.0'

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@tremble tremble mentioned this issue Jun 24, 2022
Merged
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug has_pr module module needs_triage plugins plugin (any type) labels Jun 24, 2022
@tremble tremble mentioned this issue Jun 25, 2022
Closed
2 tasks
@tremble
Copy link
Contributor Author

tremble commented Jul 10, 2022

Resolved by #1276

@tremble tremble closed this as completed Jul 10, 2022
@renovate renovate bot mentioned this issue Aug 8, 2022
Merged
1 task
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
@tremble
Wait for ec2_instances to start if we're testing state (ansible-colle…
9f3c9fc 
…ctions#1256)

Wait for ec2_instances to start if we're testing state

SUMMARY
Wait for ec2_instances to start if we're testing state, the tests have been flakey
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug has_pr module module needs_triage plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tremble @ansibullbot