Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_win_password returns success when it fails to decode the password #142

Closed
fd-davidtulloh opened this issue Jul 16, 2020 · 5 comments · Fixed by #283
Closed

ec2_win_password returns success when it fails to decode the password #142

fd-davidtulloh opened this issue Jul 16, 2020 · 5 comments · Fixed by #283
Labels
affects_2.10 needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage

Comments

@fd-davidtulloh
Copy link

SUMMARY

An unsuccessful decode call returns:

ok: [localhost] => {
        "changed": false,
        "invocation": {
            "module_args": {
               [trimmed]
            }
        },
        "win_password": ""
    }

I would expect it to return a failure state
@fd-davidtulloh fd-davidtulloh mentioned this issue Jul 19, 2020
Closed
@ansibullbot
Copy link

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@fd-davidtulloh: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type
  • ansible version
  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibullbot ansibullbot added affects_2.10 needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage labels Aug 19, 2020
@nikhilpatne
Copy link
Contributor

nikhilpatne commented Oct 27, 2020 •
edited by Akasurde
Loading

@fd-davidtulloh I am working on this issue

nikhilpatne pushed a commit to nikhilpatne/community.aws that referenced this issue Oct 29, 2020
[BUG_FIX] ec2_win_password issue ( ansible-collections#142 )
afdbbb3
@nikhilpatne nikhilpatne mentioned this issue Oct 29, 2020
Merged
@nikhilpatne
Copy link
Contributor

@fd-davidtulloh Could you please look into this PR ?

@fd-davidtulloh
Copy link
Author

fd-davidtulloh commented Nov 2, 2020 via email

tremble pushed a commit that referenced this issue Nov 9, 2020
@nikhilpatne
[BUG_FIX] ec2_win_password issue. (#283)
7b2b4f9 
* [BUG_FIX] ec2_win_password issue (  #142 )
* Creating a changelog fragment
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
@nikhilpatne
[BUG_FIX] ec2_win_password issue. (ansible-collections#283)
fbbf254 
* [BUG_FIX] ec2_win_password issue (  ansible-collections#142 )
* Creating a changelog fragment
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
@nikhilpatne
[BUG_FIX] ec2_win_password issue. (ansible-collections#283)
d6b7fe9 
* [BUG_FIX] ec2_win_password issue (  ansible-collections#142 )
* Creating a changelog fragment
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
@tremble
ec2_eni - Migrate to boto3 (ansible-collections#142)
83bba4d 
* ec2_eni: Move to boto3, add support for tags and name

Initial port from ansible/ansible#54950
Co-authored-by: Mike Healey <[email protected]>
Co-authored-by: Tim <[email protected]>
Co-authored-by: s-hertel <[email protected]>

* early retry - doesn't do anything

* Use random CIDR for VPC to reduce the risk of conflicts
Start the ec2 instances early so we don't need to wait so long for them

* Add AWSRetry to ec2_eni_info

* ec2_eni_info - Add support for eni_id

* Add minimal tests for ec2_eni
Fix association / attachment documentation
- Technically this changed with the boto2 -> boto3 migration.
  Since it's been this way for so long (Ansible 2.5), don't try adding backwards compatibility.

* Add retries to ec2_eni

* Add 'tags' as an output for ec2_eni_info for consistency

* Purging IP addresses sometimes takes time.

* Update version_added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects_2.10 needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG_FIX] ec2_win_password issue. nikhilpatne/community.aws
3 participants
@ansibullbot @nikhilpatne @fd-davidtulloh