Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tags in SSM Parameter Store #1573

Closed
1 task done
mikehas opened this issue Oct 26, 2022 · 1 comment · Fixed by #1575
Closed
1 task done

Support tags in SSM Parameter Store #1573

mikehas opened this issue Oct 26, 2022 · 1 comment · Fixed by #1575
Labels
feature This issue/PR relates to a feature request has_pr needs_triage

Comments

@mikehas
Copy link
Contributor

mikehas commented Oct 26, 2022

Summary

This feature request is to add support for adding, removing, and updating tags in the aws_ssm_parameter_store module.

Issue Type

Feature Idea

Component Name

aws_ssm_parameter_store

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
          


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 26, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          Issue/Feature ansible-collections#1573 Add support for tags in aws_ss…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          9cb5ac7
        
      

    

  

    

      
…m_parameter_store module

    




    

  




  

  

    
  


  

      

    @mikehas
mikehas



    mentioned this issue
    
      Oct 26, 2022
    





  


  

      
   Closed

  







  









      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:

None


If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  has_pr


      

  needs_triage


  labels


      Oct 26, 2022

    

  



  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 27, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ansible-collections#1573 fix linting errors
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          319be49
        
      

    

  




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 27, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ansible-collections#1573 fix pep8 errors and add changelong fragment
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          3cd745b
        
      

    

  




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 27, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ansible-collections#1573 add additional tags and purge_tags options t…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          0c6162e
        
      

    

  

    

      
…o documentation

    




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 27, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ansible-collections#1573 add additional integration test when tags pa…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          696559f
        
      

    

  

    

      
…rameter is not supplied

    




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 27, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ansible-collections#1573 fix typo in ssm_parameter example doc
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          b764b63
        
      

    

  




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 27, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ansible-collections#1573 remove unalowed variable _ from ssm_parameter
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          705d3fa
        
      

    

  




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 27, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ansible-collections#1573 fix more pep8 errors
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          298adb0
        
      

    

  




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 27, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ansible-collections#1573 import tags fragment, instead of documenting…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          f5be595
        
      

    

  

    

      
… tags as a on-off

    




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 27, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ansible-collections#1573 add resource_tags as alias to tags parameter
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          eb3b460
        
      

    

  




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 28, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ssm_parameter: add support for tags (ansible-collections#1573)
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          69973cd
        
      

    

  




    

  




  

  

    
  


  

      

    @mikehas
mikehas



    mentioned this issue
    
      Oct 28, 2022
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Oct 28, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ssm_parameter: add support for tags - add version_added parameter (an…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          c30983c
        
      

    

  

    

      
…sible-collections#1573)

    




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Nov 10, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ssm_parameter: add support for tags - remove unneeded parens and comm…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          498be45
        
      

    

  

    

      
…ented code (ansible-collections#1573)

    




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Nov 10, 2022
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ssm_parameter: add support for tags - updated docs to reflect version…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          b967485
        
      

    

  

    

      
… added (ansible-collections#1573)

    




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Jan 18, 2023
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ssm_parameter: add support for tags (ansible-collections#1573)
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          ca6fd71
        
      

    

  




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Jan 18, 2023
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ssm_parameter: add support for tags - add version_added parameter (an…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          334e643
        
      

    

  

    

      
…sible-collections#1573)

    




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Jan 18, 2023
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ssm_parameter: add support for tags - remove unneeded parens and comm…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          04eae4c
        
      

    

  

    

      
…ented code (ansible-collections#1573)

    




    

  




  


  
    
  
  

    
  mikehas 

      added a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Jan 18, 2023
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ssm_parameter: add support for tags - updated docs to reflect version…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          1ec86ff
        
      

    

  

    

      
… added (ansible-collections#1573)

    




    

  




  

  

    
  


  

    


      @tremble
tremble



        linked a pull request
        Feb 2, 2023
        that will
        close
        this issue





  

    
      ssm_parameter: add support for tags (#1573)
      #1575
  



  

      
   Merged

  







  




  


  
    
  
  

    
  tremble 

      pushed a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Feb 2, 2023
    
    

      


  

    

      


  

      
        @mikehas
      
        @tremble
  





      

        
          ssm_parameter: add support for tags (ansible-collections#1573)
        


      


      

          

    
    
    

  

      


      

      


      
      

        
          771b4f0
        
      

    

  




    

  




  


  
    
  
  

    
  tremble 

      pushed a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Feb 2, 2023
    
    

      


  

    

      


  

      
        @mikehas
      
        @tremble
  





      

        
          ssm_parameter: add support for tags - add version_added parameter (an…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          cd609e1
        
      

    

  

    

      
…sible-collections#1573)

    




    

  




  


  
    
  
  

    
  tremble 

      pushed a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Feb 2, 2023
    
    

      


  

    

      


  

      
        @mikehas
      
        @tremble
  





      

        
          ssm_parameter: add support for tags - remove unneeded parens and comm…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          474aa60
        
      

    

  

    

      
…ented code (ansible-collections#1573)

    




    

  




  


  
    
  
  

    
  tremble 

      pushed a commit
        to mikehas/community.aws
      that referenced
      this issue

    
      Feb 2, 2023
    
    

      


  

    

      


  

      
        @mikehas
      
        @tremble
  





      

        
          ssm_parameter: add support for tags - updated docs to reflect version…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          9274796
        
      

    

  

    

      
… added (ansible-collections#1573)

    




    

  




    

    









        

  
          


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Feb 2, 2023
    
    

      


  

    

      


  

      
        @mikehas
  





      

        
          ssm_parameter: add support for tags (#1573) (#1575)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          7a2b5d9
        
      

    

  

    

      
ssm_parameter: add support for tags (#1573)

SUMMARY

Adding support for tags following community guidelines and other practices from other modules. secretsmanager_secret was used along with helper functions from ec2 code. Addresses open issue for feature request #1573.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Michael Haskell (mikehas) <None>
Reviewed-by: Dennis Qian <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>

    




    

  




  


  
    
  
  

    
  patchback bot

      pushed a commit
      that referenced
      this issue

    
      Feb 2, 2023
    
    

      


  

    

      


  

      
        @mikehas
      
        @patchback
  





      

        
          ssm_parameter: add support for tags (#1573) (#1575)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          43120e3
        
      

    

  

    

      
ssm_parameter: add support for tags (#1573)

SUMMARY

Adding support for tags following community guidelines and other practices from other modules. secretsmanager_secret was used along with helper functions from ec2 code. Addresses open issue for feature request #1573.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Michael Haskell (mikehas) <None>
Reviewed-by: Dennis Qian <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 7a2b5d9)

    




    

  




  

  

    
  


  

      

    @patchback
patchback
bot


    mentioned this issue
    
      Feb 2, 2023
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Feb 2, 2023
    
    

      


  

    

      


  

      
        @patchback
  





      

        
          ssm_parameter: add support for tags (#1573) (#1575) (#1691)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          4cf180b
        
      

    

  

    

      
[PR #1575/7a2b5d98 backport][stable-5] ssm_parameter: add support for tags (#1573)

This is a backport of PR #1575 as merged into main (7a2b5d9).
SUMMARY

Adding support for tags following community guidelines and other practices from other modules. secretsmanager_secret was used along with helper functions from ec2 code. Addresses open issue for feature request #1573.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>

    




    

  











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    has_pr

  

    needs_triage









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      ssm_parameter: add support for tags (#1573)

    
      mikehas/community.aws
    





    
  




        
      

    

  
      

  

    

      2 participants
    

    

        
          @mikehas 
        
          @ansibullbot