Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to configure runtimePlatform in ECS Task Definition to use ARM #1891

Closed
1 task done
romulus-ai opened this issue Jul 20, 2023 · 0 comments · Fixed by #1892
Closed
1 task done

Unable to configure runtimePlatform in ECS Task Definition to use ARM #1891

romulus-ai opened this issue Jul 20, 2023 · 0 comments · Fixed by #1892

Comments

@romulus-ai
Copy link
Contributor

Summary

I am trying to create task definitions via Ansible, however runtimePlatform can not be configured, this means it is always the default:

    "runtimePlatform": {
        "cpuArchitecture": "X86_64",
        "operatingSystemFamily": "LINUX"
    },

Runtime Platform should be configurable to make use of ARM instances on AWS Fargate. And I am pretty sure, this way also Windows systems on fargate could be supported, however no idea if fargate supports windows currently, windows is not my area :-D

Currently I am writing a patch to support this, the issue is just to link my PR :)

Issue Type

Feature Idea

Component Name

ecs_task_definition

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
          

  

    
  


  

      

    @romulus-ai
romulus-ai



    mentioned this issue
    
      Jul 21, 2023
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Sep 7, 2023
    
    

      


  

    

      


  

      
        @romulus-ai
  





      

        
          feat: adds platform config to task definition to support ARM (#1892)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          34b06b7
        
      

    

  

    

      
feat: adds platform config to task definition to support ARM

SUMMARY
Fixes #1891
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ecs_taskdefinition
ADDITIONAL INFORMATION
I've just added the Parameter the same way the other parameters are also included. Tested it with our AWS Account.

Reviewed-by: Alina Buzachis
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Thomas Bruckmann

    




    

  




  

  

    
  


  

      

    @patchback
patchback
bot


    mentioned this issue
    
      Sep 7, 2023
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  patchback bot

      pushed a commit
      that referenced
      this issue

    
      Sep 7, 2023
    
    

      


  

    

      


  

      
        @romulus-ai
      
        @patchback
  





      

        
          feat: adds platform config to task definition to support ARM (#1892)
        

          
            
          

      


      

          

    
    
    

  

      


      

          

    
    
    

  

  

    
  



      


      
      

        
          634fdc4
        
      

    

  

    

      
feat: adds platform config to task definition to support ARM

SUMMARY
Fixes #1891
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ecs_taskdefinition
ADDITIONAL INFORMATION
I've just added the Parameter the same way the other parameters are also included. Tested it with our AWS Account.

Reviewed-by: Alina Buzachis
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Thomas Bruckmann
(cherry picked from commit 34b06b7)

    




    

  




  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Sep 7, 2023
    
    

      


  

    

      


  

      
        @patchback
  





      

        
          feat: adds platform config to task definition to support ARM (#1892) (#…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          5128acd
        
      

    

  

    

      
…1935)

[PR #1892/34b06b77 backport][stable-6] feat: adds platform config to task definition to support ARM

This is a backport of PR #1892 as merged into main (34b06b7).
SUMMARY
Fixes #1891
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ecs_taskdefinition
ADDITIONAL INFORMATION
I've just added the Parameter the same way the other parameters are also included. Tested it with our AWS Account.

Reviewed-by: Markus Bergholz <[email protected]>

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      feat: adds platform config to task definition to support ARM

    
      romulus-ai/community.aws
    





    
  




        
      

    

  
      

  

    

      1 participant
    

    

        
          @romulus-ai