elb_target_group doesn't change health_check_path on existing target group

[briantist]

Resubmitted from ansible-collections/amazon.aws#15

SUMMARY

The health_check_path option is ignored on an existing target group. Changing it gives a status of ok and the setting is not changed.

I suspect this affects more health check options but haven't tried them.

Turns out this is a duplicate of ansible/ansible#50024

You have to supply health_check_protocol in order for health_check_path to be considered.

But the documentation still doesn't reflect that.

And really, the purpose of the check for the protocol is to ignore other params that only apply to http and https protocols. The check should:

1. Throw an error (at least a warning?) when the options that don't apply to your protocol are supplied
2. Assume the health_check_protocol is the same as protocol if the former is not supplied, since that's what happens in reality

So I think this should remain open.

ISSUE TYPE

• Bug Report

COMPONENT NAME

elb_target_group

ANSIBLE VERSION

2.9

CONFIGURATION

OS / ENVIRONMENT

STEPS TO REPRODUCE

• Create target group
• Change the health_check_path option to something else
• Run again

EXPECTED RESULTS

• changed status with updated value

ACTUAL RESULTS

• ok status with no change

[ansibullbot]

Files identified in the description:

• plugins/modules/elb_target_group.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @jillr @s-hertel @tremble @wimnat
click here for bot help