route53: error when creating records in private zone with vpc_id

[boutetnico]

SUMMARY

route53 has a special behaviour when working on private zones and vpc_id option is provided. As stated in documentation:

When used in conjunction with private_zone: true, this will only modify records in the private hosted zone attached to this VPC.
This allows you to have multiple private hosted zones, all with the same name, attached to different VPCs.

The following error occurs when creating or updating a record in such zone: AttributeError: 'dict' object has no attribute 'id'.

In case anyone wonders, this is not a duplicate of #434 because no vpc_id option is used there.

I'll provide a PR soon.

ISSUE TYPE

• Bug Report

COMPONENT NAME

route53

ANSIBLE VERSION

ansible 2.10.5
  config file = /home/admin/ansible/ansible.cfg
  configured module search path = ['/home/admin/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.7.3 (default, Jul 25 2020, 13:03:44) [GCC 8.3.0]

CONFIGURATION

ALLOW_WORLD_READABLE_TMPFILES(/home/admin/ansible/ansible.cfg) = True
ANSIBLE_SSH_CONTROL_PATH(/home/admin/ansible/ansible.cfg) = %(directory)s/%%h-%%p-%%r
DEFAULT_NO_TARGET_SYSLOG(/home/admin/ansible/ansible.cfg) = True
DEFAULT_ROLES_PATH(/home/admin/ansible/ansible.cfg) = ['/home/admin/ansible/roles']
INTERPRETER_PYTHON(/home/admin/ansible/ansible.cfg) = /usr/bin/python3
RETRY_FILES_ENABLED(/home/admin/ansible/ansible.cfg) = False

OS / ENVIRONMENT

Debian 10

STEPS TO REPRODUCE

Ensure a private zone exists, then run the following task.

- hosts: all
  tasks:
      route53:
        aws_access_key: "{{ aws_access_key }}"
        aws_secret_key: "{{ aws_secret_key }}"
        overwrite: true
        private_zone: true
        record: "test-ansible.internal.example.com"
        state: present
        type: A
        value: "1.2.3.4"
        vpc_id: vpc-xyz1234
        zone: "internal.example.com"

EXPECTED RESULTS

The record is created inside the zone.

ACTUAL RESULTS

An error occured.

The full traceback is:
Traceback (most recent call last):
  File "/home/admin/.ansible/tmp/ansible-tmp-1617023331.5792427-11521-49668929273150/AnsiballZ_route53.py", line 102, in <module>
    _ansiballz_main()
  File "/home/admin/.ansible/tmp/ansible-tmp-1617023331.5792427-11521-49668929273150/AnsiballZ_route53.py", line 94, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File "/home/admin/.ansible/tmp/ansible-tmp-1617023331.5792427-11521-49668929273150/AnsiballZ_route53.py", line 40, in invoke_module
    runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.route53', init_globals=None, run_name='__main__', alter_sys=True)
  File "/usr/lib/python3.7/runpy.py", line 205, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 96, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmp/ansible_route53_payload_n6znsp0f/ansible_route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py", line 626, in <module>
  File "/tmp/ansible_route53_payload_n6znsp0f/ansible_route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py", line 529, in main
  File "/tmp/ansible_route53_payload_n6znsp0f/ansible_route53_payload.zip/ansible_collections/community/aws/plugins/modules/route53.py", line 413, in get_zone_id_by_name
AttributeError: 'dict' object has no attribute 'id'

[ansibullbot]

Files identified in the description:

• [plugins/modules/route53.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/route53.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @jillr @jimbydamonk @s-hertel @tremble @wimnat
click here for bot help