Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ECS ContainerDependency - DependsOn parameter #520

Closed
AlexJov opened this issue Apr 3, 2021 · 3 comments · Fixed by #534
Closed

Enable ECS ContainerDependency - DependsOn parameter #520

AlexJov opened this issue Apr 3, 2021 · 3 comments · Fixed by #534
Assignees
Labels
feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)

Comments

@AlexJov
Copy link

AlexJov commented Apr 3, 2021

SUMMARY

Enabling init containers when describing Containers with ECS TaskDefinitions by adding depends_on task configuration option.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

ecs_taskdefinition

ANSIBLE VERSION
> ansible --version
ansible 2.10.4
python version = 3.9.1
ADDITIONAL INFORMATION

Having container dependencies is supported by boto3 lib:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecs.html#ECS.Client.register_task_definition

However, at the moment is not part of the available parameters to pass with AWS community Ansible collection:

response = self.ecs.register_task_definition(**params)

What this feature would enable is having an init container to deliver binaries, for example monitoring (APM) agent files, before starting the essential container with the application.
Without the dependsOn option available, in case of this example, the application starts before files are mounted from the agent's container and fail to attach an agent, or in some cases fails completely.

@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Apr 3, 2021
@alinabuzachis alinabuzachis self-assigned this Apr 8, 2021
@alinabuzachis
Copy link
Contributor

alinabuzachis commented Apr 21, 2021

Hi @AlexJov, thank you for raising this issue. It seems this parameter is already supported but it was not properly documented in the Ansible module. dependsOn parameter requires platform version >= 1.3.0 for tasks that use the Fargate launch type. Let me know please if it works for you. Thank you.

alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
Use module_util helper for tagging AMIs

SUMMARY
We have some helpers for tagging EC2 resources, use them for tagging AMIs.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_ami
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants