Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route53 idempotency issues #524

Closed
felixfontein opened this issue Apr 5, 2021 · 4 comments · Fixed by #525
Closed

route53 idempotency issues #524

felixfontein opened this issue Apr 5, 2021 · 4 comments · Fixed by #525
Labels
bug This issue/PR relates to a bug module module needs_triage plugins plugin (any type)

Comments

@felixfontein
Copy link
Contributor

felixfontein commented Apr 5, 2021 •
edited
Loading

SUMMARY

Since #405, route53 has several idempotency issues when running with -C --diff:

  1. it tries to change CAA entries where the values are in a different order;
  2. it tries to re-add wildcard records that already exist.
ISSUE TYPE
  • Bug Report
COMPONENT NAME

route53

ANSIBLE VERSION
devel
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @jillr @jimbydamonk @s-hertel @tremble @wimnat
click here for bot help

@felixfontein
Copy link
Contributor Author

  1. is a regression for route53: fix CAA record ordering for idempotency ansible/ansible#46049.

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module needs_triage plugins plugin (any type) labels Apr 5, 2021
@felixfontein
Copy link
Contributor Author

  1. is caused by removing the escaped character handling (see for example route53: improve octal encoded characters handling ansible/ansible#60508).

@felixfontein felixfontein mentioned this issue Apr 5, 2021
Merged
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
@alinabuzachis
NAT Gateway use module_utils helper for tag management (ansible-colle…
1d8583f 
…ctions#524)

NAT Gateway use module_utils helper for tag management

SUMMARY


NAT Gateway use module_utils helper for tag management
Cleaning


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ec2_vpc_nat_gateway

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module needs_triage plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix route53 idempotency issues felixfontein/community.aws
2 participants
@felixfontein @ansibullbot