All _info/_facts modules must work in check_mode #659

felixfontein · 2021-07-28T06:05:34Z

Summary

There are multiple _info/_facts modules in this collection which do not support check_mode.

ERROR: plugins/modules/aws_sgw_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: required key not provided @ data['supports_check_mode']. Got None
ERROR: plugins/modules/cloudformation_exports_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: not a valid value for dictionary value @ data['supports_check_mode']. Got False
ERROR: plugins/modules/cloudfront_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: not a valid value for dictionary value @ data['supports_check_mode']. Got False
ERROR: plugins/modules/ec2_asg_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: required key not provided @ data['supports_check_mode']. Got None
ERROR: plugins/modules/ec2_lc_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: required key not provided @ data['supports_check_mode']. Got None
ERROR: plugins/modules/iam_mfa_device_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: required key not provided @ data['supports_check_mode']. Got None
ERROR: plugins/modules/iam_server_certificate_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: required key not provided @ data['supports_check_mode']. Got None
ERROR: plugins/modules/wafv2_resources_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: required key not provided @ data['supports_check_mode']. Got None
ERROR: plugins/modules/wafv2_web_acl_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: required key not provided @ data['supports_check_mode']. Got None

Issue Type

Bug Report

Component Name

plugins/modules/aws_sgw_info.py
plugins/modules/cloudformation_exports_info.py
plugins/modules/cloudfront_info.py
plugins/modules/ec2_asg_info.py
plugins/modules/ec2_lc_info.py
plugins/modules/iam_mfa_device_info.py
plugins/modules/iam_server_certificate_info.py
plugins/modules/wafv2_resources_info.py
plugins/modules/wafv2_web_acl_info.py

Ansible Version

--

Collection Versions

latest development version

AWS SDK versions

--

Configuration

--

OS / Environment

--

Steps to Reproduce

--

Expected Results

--

Actual Results

--

Code of Conduct

I agree to follow the Ansible Code of Conduct

The text was updated successfully, but these errors were encountered:

ansibullbot · 2021-07-28T06:06:32Z

Files identified in the description:

[plugins/modules/aws_sgw_info.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/aws_sgw_info.py)
[plugins/modules/cloudformation_exports_info.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/cloudformation_exports_info.py)
[plugins/modules/cloudfront_info.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/cloudfront_info.py)
[plugins/modules/ec2_asg_info.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/ec2_asg_info.py)
[plugins/modules/ec2_lc_info.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/ec2_lc_info.py)
[plugins/modules/iam_mfa_device_info.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/iam_mfa_device_info.py)
[plugins/modules/iam_server_certificate_info.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/iam_server_certificate_info.py)
[plugins/modules/wafv2_resources_info.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/wafv2_resources_info.py)
[plugins/modules/wafv2_web_acl_info.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/wafv2_web_acl_info.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibullbot · 2021-07-28T06:06:33Z

cc @jillr @linuxdynasty @markuman @mmoyle @nerzhul @psykotox @pwnall @s-hertel @tremble @wilvk @wimnat
click here for bot help

https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#development-conventions https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html#following-ansible-conventions ansible/ansible#75324 fixes: ansible-collections#659

@felixfontein

Update remaining _info modules so that they run in check_mode SUMMARY Update remaining _info modules so that they run in check_mode https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#development-conventions https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html#following-ansible-conventions fixes: #659 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_sgw_info ec2_asg_info ec2_lc_info iam_mfa_device_info iam_server_certificate_info wafv2_resources_info wafv2_web_acl_info ADDITIONAL INFORMATION cc: @felixfontein It would be good to get this in before the upcoming sanity check: ansible/ansible#75324 amazon.aws/pull/405 Depends-on: ansible/ansible-zuul-jobs#1014 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Felix Fontein <None> Reviewed-by: None <None>

Add supports_check_mode to cloudformation_exports_info cloudfront_info SUMMARY as _info modules they should run in check mode See also #659 (missed in my first pass) ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudformation_exports_info cloudfront_info ADDITIONAL INFORMATION https://dashboard.zuul.ansible.com/t/ansible/build/a5f8c6effd7745eca0b06a5a1bef7b08 ERROR: plugins/modules/cloudformation_exports_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: not a valid value for dictionary value @ data['supports_check_mode']. Got False ERROR: plugins/modules/cloudfront_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: not a valid value for dictionary value @ data['supports_check_mode']. Got False Reviewed-by: Jill R <None> Reviewed-by: None <None>

https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#development-conventions https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html#following-ansible-conventions ansible/ansible#75324 fixes: ansible-collections/community.aws#659

https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#development-conventions https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html#following-ansible-conventions ansible/ansible#75324 fixes: ansible-collections/community.aws#659 This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@8081e69

ansibullbot added bug This issue/PR relates to a bug module module needs_triage plugins plugin (any type) labels Jul 28, 2021

tremble mentioned this issue Jul 28, 2021

Update remaining _info modules so that they run in check_mode #660

Merged

ansible-zuul bot closed this as completed in #660 Aug 3, 2021

tremble mentioned this issue Aug 6, 2021

Add supports_check_mode to cloudformation_exports_info cloudfront_info #676

Merged

tremble mentioned this issue May 18, 2022

compare_aws_tags should ignore tags with the prefix 'aws:' ansible-collections/amazon.aws#817

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

All _info/_facts modules must work in check_mode #659

All _info/_facts modules must work in check_mode #659

felixfontein commented Jul 28, 2021

ansibullbot commented Jul 28, 2021

ansibullbot commented Jul 28, 2021

All _info/_facts modules must work in check_mode #659

All _info/_facts modules must work in check_mode #659

Comments

felixfontein commented Jul 28, 2021

Summary

Issue Type

Component Name

Ansible Version

Collection Versions

AWS SDK versions

Configuration

OS / Environment

Steps to Reproduce

Expected Results

Actual Results

Code of Conduct

ansibullbot commented Jul 28, 2021

ansibullbot commented Jul 28, 2021