Add state "disabled" to route53_health_check module

[sydoluciani]

SUMMARY

Moving issue #49019 from Ansible repository:
In module "route53_health_check" it would be helpful to be able to deactivate health checks.
My use case is to disable/deactivate health checks during a deployment and afterwards reenable them.
In the AWS Route 53 console it can be done via "Advanced Configuration" by checking "Disable health check". This option considers the health check positive as long as it is deactivated.

ISSUE TYPE

• Feature Idea

COMPONENT NAME

route53_health_check

ADDITIONAL INFORMATION

I think the simplest way would be to add the state "disabled". So new health checks can be created in a disabled state or existing health checks will get disabled.

The other option would be to add the flag "disabled" additionally to the "present" state.

- route53_health_check:
    state: disabled
    fqdn: host1.example.com
    type: HTTPS
    resource_path: /
  register: my_health_check

[sydoluciani]

@zimbatm Do you have time to add this feature ? apparently Boto is providing the same API version as Boto3, and we only need to add Disabled option to couple of places including here and here

Or let me know if you have time to review the change, then I will make the required changes, and you can review.

[zimbatm]

Sorry, my time is quite limited and I don't use Ansible anymore so my interest quite limited as well.

[ansibullbot]

cc @jillr @s-hertel @tremble @wimnat
click here for bot help

[badnetmask]

I'm signing up to see if I can implement this.

[badnetmask]

@sydoluciani -- apparently I was able to do it. If you could test the branch, I would appreciate.

@jillr @tremble -- I've had issues writing integration tests for for this and for #565. I have intention to deal with these tests in a different PR, once both that and #573 are merged. Let me know your thoughts.

[markuman]

Implemented by #756
With the next upcomming release 2.1.0 the boolean parameter disabled will be supported.

Thank you all for the work.