Backport: elb_application_lb - check_mode support, alb attributes, vpc default sg #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsible-collections#894) add check_mode for elb_application_lb* & refactor integration tests SUMMARY Add check_mode support for elb_application_lb* & refactor integration tests. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb elb_application_lb_info Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Mark Woolley <[email protected]> (cherry picked from commit 239136b)
elb_application_lb - support alb attributes SUMMARY Support modifying different alb specific attributes Fixes ansible-collections#571 Depends-On ansible-collections/amazon.aws#696 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 85bfce4)
…le-collections#971) elb_application_lb - treat empty security group as VPC default SUMMARY Fixes idempotency issue when security_groups = [] by treating [] as using the VPC's default security group (like it does on creation). Fixes ansible-collections#28 Used same logic as amazon.aws.ec2_vpc_route_table does for using default igw Added integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Woolley <[email protected]> (cherry picked from commit 20b726a)
ansibullbot
added
community_review
feature
markuman
approved these changes
Mar 28, 2022
alinabuzachis
approved these changes
Mar 29, 2022
softwarefactory-project-zuul
bot
merged commit aac1f34
into
ansible-collections:stable-3
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…#1025) Cleanup after 4.2.0 Release SUMMARY With 4.2.0 tagged we now need to forward-port the changelog updates from 4.2.0 ISSUE TYPE Docs Pull Request COMPONENT NAME CHANGELOG.rst changelogs/changelog.yaml changelogs/fragments/ ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport #894 #963 #971 manually to resolve conflicts.
ISSUE TYPE
COMPONENT NAME
elb_application_lb