Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iam_policy - update examples, add RETURN, add required_if case #1093

Conversation

jatorcasso
Copy link
Contributor

SUMMARY
  • fix broken example
  • add RETURN documentation
  • require one of policy_document or policy_json when state is present
  • add extra integration tests for check mode idempotency cases
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iam_policy

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Apr 26, 2022
@markuman markuman added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Apr 26, 2022
@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Apr 26, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c978414 into ansible-collections:main Apr 26, 2022
@patchback
Copy link

patchback bot commented Apr 26, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/c97841482bff44038ae357d625cc27a11c8efed0/pr-1093

Backported as #1096

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 26, 2022
iam_policy - update examples, add RETURN, add required_if case

SUMMARY

fix broken example
add RETURN documentation
require one of policy_document or policy_json when state is present
add extra integration tests for check mode idempotency cases

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_policy

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit c978414)
@patchback
Copy link

patchback bot commented Apr 26, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/c97841482bff44038ae357d625cc27a11c8efed0/pr-1093

Backported as #1097

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 26, 2022
iam_policy - update examples, add RETURN, add required_if case

SUMMARY

fix broken example
add RETURN documentation
require one of policy_document or policy_json when state is present
add extra integration tests for check mode idempotency cases

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_policy

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit c978414)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 6, 2022
#1097)

[PR #1093/c9784148 backport][stable-3] iam_policy - update examples, add RETURN, add required_if case

This is a backport of PR #1093 as merged into main (c978414).
SUMMARY

fix broken example
add RETURN documentation
require one of policy_document or policy_json when state is present
add extra integration tests for check mode idempotency cases

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_policy

Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 6, 2022
#1096)

[PR #1093/c9784148 backport][stable-2] iam_policy - update examples, add RETURN, add required_if case

This is a backport of PR #1093 as merged into main (c978414).
SUMMARY

fix broken example
add RETURN documentation
require one of policy_document or policy_json when state is present
add extra integration tests for check mode idempotency cases

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_policy

Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…le-collections#1093)

iam_policy - update examples, add RETURN, add required_if case

SUMMARY

fix broken example
add RETURN documentation
require one of policy_document or policy_json when state is present
add extra integration tests for check mode idempotency cases

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_policy

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@c978414
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
inventory/aws_ec2: extend unit-test coverage

Depends-On: ansible-collections#1090
Break up the _populate() method into smaller function. Use @classmethod when possible and
reduce the use of get_option() to avoid side-effects.

Reviewed-by: Mark Chappell <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants