aws_secret - Support purge_tags #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
markuman
reviewed
May 19, 2022
ansibullbot
added
WIP
This comment was marked as outdated.
This comment was marked as outdated.
tremble
changed the title
1 task
|
While the integration tests could be further expanded for the non-tag parameters, I'm going to leave them as-is for now. If someone makes other changes to other parameters then we can get them to expand them for that parameter. |
tremble
commented
May 20, 2022
Comment on lines
-40
to
-43
| - result.arn is not none | ||
| - result.name is not none | ||
| - result.tags is not none | ||
| - result.version_ids_to_stages is not none |
There was a problem hiding this comment.
This wasn't actually doing what the author thought it was doing. The values were actually all in result.secret
| @@ -139,6 +153,29 @@ | |||
| returned: always | |||
| type: dict | |||
| sample: { "dc1ed59b-6d8e-4450-8b41-536dfe4600a9": [ "AWSCURRENT" ] } | |||
| tags: | |||
There was a problem hiding this comment.
Don't we also need to add version_added also for this returned parameter (even it's not new)?
There was a problem hiding this comment.
My thought was no. It's been there since the start of the collection, it just wasn't documented.
alinabuzachis
approved these changes
May 20, 2022
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…collections#1150) ec2_instance: fix to handle create instance in specified AZ SUMMARY This PR adds a fix to allow launching an instance in specified AZ when vpc_subnet_id is not specified. The current code does not consider the AZ and launches the instance in default subnet of default vpc for the specified region. https://github.com/ansible-collections/amazon.aws/blob/main/plugins/modules/ec2_instance.py#L1584-L1593 Fixes ansible-collections#1120 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Without the fix, the below playbook will launch instance in default subnet ignoring specified AZ. Example Playbook to launch instance in us-west-2b AZ. --- - name: Spin up ec2 instance hosts: localhost gather_facts: false tasks: - name: Launch regular ec2 instances in us-west-1b amazon.aws.ec2_instance: name: "test-instance-us-west-1b" instance_type: t2.micro image_id: ami-xxxxx state: present availability_zone: us-west-1b region: us-west-1 tags: terminate-this: yes network: assign_public_ip: yes register: create_result - ec2_instance_info: instance_ids: - "{{ create_result.instance_ids[0] }}" region: us-west-1 register: info_result - assert: that: info_result.instances[0].placement.availability_zone == 'us-west-1b' Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
aws_secret currently defaults to purging all tags (even if tags isn't specified), this is a little aggressive.
tags: {}is set (rather than whentags is NoneISSUE TYPE
COMPONENT NAME
aws_secret
ADDITIONAL INFORMATION
Related to #1146