lambda_info - refactor to fix bug when querying all lambdas #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jillr @markuman @pjodouin @s-hertel @steynovich @tremble |
ansibullbot
added
bug
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
async causing the problem: |
tremble
approved these changes
May 23, 2022
There was a problem hiding this comment.
Depending on how many lambdas people have, this is potentially going to massively increase the default runtime when listing all lambdas.
I agree that only supporting the minimal query is definitely wrong (unless we make name and query mutually exclusive), however, based on my experience with other APIs, flipping the switch so that it defaults to making almost an order of magnitude more queries is likely to have a significant negative effect for anyone with a larger setup.
If this is to be backported I'd want to see the current behaviour preserved:
- default to "query=config" when the function isn't specified
- default to "query=all" when the function is specified
BUT, if query is explicitly set (currently 'all' is a default, so be careful), then that should override the default behaviour.
I'm approving for 4.0.0, but want to be clear I do not think the current PR should be backported.
tremble
requested changes
May 23, 2022
Co-authored-by: Jill R <[email protected]>
tremble
approved these changes
May 25, 2022
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
recheck |
|
@tremble can we backport this now with the updated changes? |
tremble
approved these changes
Jun 1, 2022
tremble
added
mergeit
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1188 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
lambda_info - refactor to fix bug when querying all lambdas Depends-On: ansible/ansible-zuul-jobs#1558 SUMMARY Fix bug that forces query: config when getting info for all lambdas. Refactored to return the expected info Add extra cleanup at end of tests Fixes #1151 ISSUE TYPE Bugfix Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION This module also currently returns a dict of dicts (as opposed to a list of dicts), but I wanted to keep the scope of this PR to fixing the bug. Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> (cherry picked from commit 0c76aed)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
…1188) [PR #1152/0c76aedd backport][stable-3] lambda_info - refactor to fix bug when querying all lambdas This is a backport of PR #1152 as merged into main (0c76aed). Depends-On: ansible/ansible-zuul-jobs#1558 SUMMARY Fix bug that forces query: config when getting info for all lambdas. Refactored to return the expected info Add extra cleanup at end of tests Fixes #1151 ISSUE TYPE Bugfix Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION This module also currently returns a dict of dicts (as opposed to a list of dicts), but I wanted to keep the scope of this PR to fixing the bug. Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…collections#1152) lambda_info - refactor to fix bug when querying all lambdas Depends-On: ansible/ansible-zuul-jobs#1558 SUMMARY Fix bug that forces query: config when getting info for all lambdas. Refactored to return the expected info Add extra cleanup at end of tests Fixes ansible-collections#1151 ISSUE TYPE Bugfix Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION This module also currently returns a dict of dicts (as opposed to a list of dicts), but I wanted to keep the scope of this PR to fixing the bug. Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@0c76aed
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Use missing_required_lib more consistently SUMMARY The developer docs recomment using missing_required_lib rather than a custom error message: https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_best_practices.html#importing-and-using-shared-code ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py plugins/lookup/aws_account_attribute.py plugins/lookup/aws_secret.py plugins/lookup/aws_ssm.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1558
SUMMARY
query: configwhen getting info for all lambdas. Refactored to return the expected infoFixes #1151
ISSUE TYPE
COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION
This module also currently returns a dict of dicts (as opposed to a list of dicts), but I wanted to keep the scope of this PR to fixing the bug.