Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for profile becoming mutually exclusive with other access tokens #1155

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 24, 2022

Depends-On: ansible-collections/amazon.aws#834

SUMMARY

amazon.aws/834 made profile mutually exclusive with the other access token parameters, add a changelog fragment to community.aws since it's a significant change that also affects this collection

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

changelogs/fragments/151-profile-mutually-exclusive.yml

ADDITIONAL INFORMATION

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label May 24, 2022
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request owner_pr PR created by owner/maintainer labels May 24, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 48s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 45s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 07s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 01s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 09s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 40s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 10s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 27s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 51s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 15s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 30s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 39s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 25s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 09s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 36s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b826728 into ansible-collections:main May 26, 2022
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble deleted the deprecation/4.0.0/profile branch July 7, 2022 19:27
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…aws in 5.0.0 (ansible-collections#1155)

Update version_added information for modules which migrate to amazon.aws in 5.0.0

SUMMARY
Felix has pointed out in IRC/Matrix that for modules which migrated to amazon.aws it can be a little confusing when you try to look back in logs to find exactly what needs to be installed for a feature (installing amazon.aws.4.3.0 doesn't guarantee that community.aws 4.x is installed)
Update the main 'version_added' to match the version that the modules were moved to amazon.aws, and add the version_added_collection for existing new features.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various modules
ADDITIONAL INFORMATION
Scope is currently limited to the 5.0.0 migrations, to simplify backports.  If accepted I'll cleanup the 4.0.0 and 2.0.0 modules too.

Reviewed-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) owner_pr PR created by owner/maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants