Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3_lifecycle - drop deprecated requester_pays parameter #1165

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 25, 2022

SUMMARY

The requester_pays did nothing, drop it.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

s3_lifecycle

ADDITIONAL INFORMATION

See also: ansible/ansible#63989

@github-actions
Copy link

github-actions bot commented May 25, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review labels May 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 26s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 42s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 47s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 16s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 11s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 55s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 35s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 13s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 22m 44s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label May 25, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 16s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 31s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 18s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 48s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 54s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 50s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 47s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 27s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 23m 35s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 60cd794 into ansible-collections:main May 26, 2022
@tremble tremble deleted the deprecation/4.0.0/s3_lifecycle branch July 7, 2022 19:27
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ec2_ami: refactoring and unit-test coverage

Refactoring and unit-test coverage of the ec2_ami.

Break up the long create_image(), deregister_image(), update_image()
Use classes and static methods to group the functions
Use more Pythonic expression when possible
Handle internal failures with exception to simplify the error managment

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mike Graves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants