Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog fragment for amazon.aws/825 #1174

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 27, 2022

SUMMARY

With ansible-collections/amazon.aws#825 we now ignore aws: tags when purging.

Since affects both amazon.aws and community.aws add a changelog note to community.aws

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

changelogs/fragments/817-skip_purge_aws.yaml

ADDITIONAL INFORMATION

See also:
ansible-collections/amazon.aws#825
ansible-collections/amazon.aws#817
#1146

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label May 27, 2022
@ansibullbot ansibullbot added community_review docs owner_pr PR created by owner/maintainer labels May 27, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 3m 40s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 19s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 16s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 21s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 37s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 52s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 15s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 32s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 05s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 59s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 16m 52s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 10s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 34s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 12s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e6410b5 into ansible-collections:main May 30, 2022
@tremble tremble deleted the issues/amazon.aws/817 branch July 7, 2022 19:27
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ansible-collections#1174)

Refacterization of code to use 'fallback' instead of using os.environ

SUMMARY
When the "ec2" module was first added, it included support for pulling credentials out of the environment variables.  3.5 years later, in Ansible 2.1, support for configuring a 'fallback' directly in the argument specification was added, but we never got around to using it.
This PR finally cleans up the code and lets the argument parser directly handle fallback to environment variables.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/botocore.py
plugins/module_utils/modules.py
ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary docs mergeit Merge the PR (SoftwareFactory) owner_pr PR created by owner/maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants