ecs_service and ecs_service_info: add name and service aliases #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuman
added
backport-2
ansibullbot
added
bug
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
alinabuzachis
approved these changes
May 31, 2022
jatorcasso
reviewed
May 31, 2022
the alias feature comes from ansible itself? it's not something that is invented by amazon.aws/community.aws? |
jatorcasso
approved these changes
May 31, 2022
tremble
approved these changes
Jun 1, 2022
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #1192 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
ecs_service and ecs_service_info: add name and service aliases SUMMARY while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose. this PR adds just aliases to both modules, to use the same parameter to address the ecs service name. ref #1142 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ecs_service_info Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 029333b)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1193 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
ecs_service and ecs_service_info: add name and service aliases SUMMARY while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose. this PR adds just aliases to both modules, to use the same parameter to address the ecs service name. ref #1142 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ecs_service_info Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 029333b)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
#1193) [PR #1187/029333b3 backport][stable-3] ecs_service and ecs_service_info: add name and service aliases This is a backport of PR #1187 as merged into main (029333b). SUMMARY while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose. this PR adds just aliases to both modules, to use the same parameter to address the ecs service name. ref #1142 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ecs_service_info Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
#1192) [PR #1187/029333b3 backport][stable-2] ecs_service and ecs_service_info: add name and service aliases This is a backport of PR #1187 as merged into main (029333b). SUMMARY while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose. this PR adds just aliases to both modules, to use the same parameter to address the ecs service name. ref #1142 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ecs_service_info Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
ec2_instance - avoid changing module.params SUMMARY Update ec2_instance so that module.params isn't modified ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
while
ecs_serviceis usingnamefor the service name parameter,ecs_service_infois usingservicefor the same purpose.this PR adds just aliases to both modules, to use the same parameter to address the ecs service name.
ref #1142
ISSUE TYPE
COMPONENT NAME
ecs_service
ecs_service_info