Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging fragment - rds_instance_snapshot - Move over to the docs fragment. #1200

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 2, 2022

SUMMARY

The rds_instance_snapshot tests are slow enough to cause test timeouts when combined with too many other changed, split this off.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rds_instance_snapshot

ADDITIONAL INFORMATION

The change itself was approved on #1182

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jun 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 3m 56s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 50s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 36s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 25s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 32s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 21s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 17s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 43s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-community.aws-1 SUCCESS in 25m 03s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble
Copy link
Contributor Author

tremble commented Jun 2, 2022

I'm going to merge this based on the approvals from #1182 The change was part of 1182 at the time the code was approved, I just had to split the PR so the tests didn't timeout.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 50s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 48s
✔️ ansible-test-sanity-docker-devel SUCCESS in 14m 15s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 59s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 56s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 06s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 33s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 30s
✔️ ansible-test-splitter SUCCESS in 2m 31s
✔️ integration-community.aws-1 SUCCESS in 23m 04s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9ca5540 into ansible-collections:main Jun 2, 2022
@tremble tremble deleted the tagging/docs_slow/rds_instance_snapshot branch July 7, 2022 19:23
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1200)

Tagging fragment - rds_instance_snapshot - Move over to the docs fragment.

SUMMARY
The rds_instance_snapshot tests are slow enough to cause test timeouts when combined with too many other changed, split this off.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot
ADDITIONAL INFORMATION
The change itself was approved on ansible-collections#1182

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@9ca5540
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…nsible-collections#1200)

route53_health_check: Add health_check info on updating health check

SUMMARY

Fixes ansible-collections#1190
Added health check info in output when updating a Route53 health check with use_unique_names: true.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

route53_health_check

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: GomathiselviS <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants