-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging fragment - rds_instance_snapshot - Move over to the docs fragment. #1200
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:tagging/docs_slow/rds_instance_snapshot
Jun 2, 2022
Merged
Tagging fragment - rds_instance_snapshot - Move over to the docs fragment. #1200
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:tagging/docs_slow/rds_instance_snapshot
Jun 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
labels
Jun 2, 2022
I'm going to merge this based on the approvals from #1182 The change was part of 1182 at the time the code was approved, I just had to split the PR so the tests didn't timeout. |
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…sible-collections#1200) Tagging fragment - rds_instance_snapshot - Move over to the docs fragment. SUMMARY The rds_instance_snapshot tests are slow enough to cause test timeouts when combined with too many other changed, split this off. ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot ADDITIONAL INFORMATION The change itself was approved on ansible-collections#1182 This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@9ca5540
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#1200) route53_health_check: Add health_check info on updating health check SUMMARY Fixes ansible-collections#1190 Added health check info in output when updating a Route53 health check with use_unique_names: true. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_health_check Reviewed-by: Mike Graves <[email protected]> Reviewed-by: GomathiselviS <None> Reviewed-by: Mandar Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The rds_instance_snapshot tests are slow enough to cause test timeouts when combined with too many other changed, split this off.
ISSUE TYPE
COMPONENT NAME
rds_instance_snapshot
ADDITIONAL INFORMATION
The change itself was approved on #1182