Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging - Add resource_tags as an alias for tags #1204

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 3, 2022

SUMMARY

There are a number of modules where we always create a fresh resource. For now let's just add resource_tags, long term it would be good to add purge_tags and use the docs fragment.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/data_pipeline.py
plugins/modules/ec2_ami_copy.py
plugins/modules/ec2_launch_template.py
plugins/modules/ecs_task.py

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jun 3, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble tremble force-pushed the tagging/resource_tags/1204 branch from 807d9f1 to ed5f5e8 Compare June 3, 2022 11:22
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 5m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 51s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 01s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 10s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 08s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 23s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 45s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 17s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 14s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-community.aws-1 SUCCESS in 6m 26s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 3, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 47s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 45s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 12s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 33s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 26s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 43s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 52s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 46s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 45s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-community.aws-1 SUCCESS in 7m 04s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 11fcdea into ansible-collections:main Jun 3, 2022
@tremble tremble deleted the tagging/resource_tags/1204 branch July 7, 2022 19:23
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…#1204)

Tagging - Add resource_tags as an alias for tags

SUMMARY
There are a number of modules where we always create a fresh resource.  For now let's just add resource_tags, long term it would be good to add purge_tags and use the docs fragment.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/data_pipeline.py
plugins/modules/ec2_ami_copy.py
plugins/modules/ec2_launch_template.py
plugins/modules/ecs_task.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@11fcdea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants