Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wafv2_web_acl - fix return values #1216

Merged
merged 1 commit into from
Jun 7, 2022
Merged

wafv2_web_acl - fix return values #1216

merged 1 commit into from
Jun 7, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 4, 2022

SUMMARY
  • split integration tests from full wafv2 tests
  • relax botocore requirement to bare minimum required
  • return web acl info on update
  • consistently return web acl info as described in documentation (create would nest it under "web_acl")
  • fix "changed" value when description not specified
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

wafv2_web_acl

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Jun 4, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 4, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@tremble tremble force-pushed the wafv2_web_acl/description branch from 5db15b8 to 7de6ab2 Compare June 4, 2022 20:57
@tremble tremble requested a review from markuman June 4, 2022 20:58
@tremble tremble added the backport-3 PR should be backported to the stable-3 branch label Jun 4, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 3m 56s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 22s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 00s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 14s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 16s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 24s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 14m 35s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 36m 08s
✔️ ansible-test-splitter SUCCESS in 2m 36s
✔️ integration-community.aws-1 SUCCESS in 6m 52s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble mentioned this pull request Jun 5, 2022
Merged
jatorcasso
jatorcasso reviewed Jun 6, 2022
View reviewed changes
Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM - added an addtl change to make

plugins/modules/wafv2_web_acl.py Show resolved Hide resolved
tests/integration/targets/wafv2_web_acl/tasks/description.yml Show resolved Hide resolved
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 5m 02s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 35s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 53s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 21s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 04s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 04s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 39s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 44s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 48s
✔️ ansible-test-splitter SUCCESS in 3m 04s
✔️ integration-community.aws-1 SUCCESS in 7m 03s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 01f3274 into ansible-collections:main Jun 7, 2022
@patchback
Copy link

patchback bot commented Jun 7, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/01f3274762d475922db6b6c8ccca468cbae92905/pr-1216

Backported as #1227

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 7, 2022
@tremble @patchback
wafv2_web_acl - fix return values (#1216)
1e3fa70 
wafv2_web_acl - fix return values

SUMMARY

split integration tests from full wafv2 tests
relax botocore requirement to bare minimum required
return web acl info on update
consistently return web acl info as described in documentation (create would nest it under "web_acl")
fix "changed" value when description not specified

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_web_acl
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 01f3274)
@patchback patchback bot mentioned this pull request Jun 7, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 8, 2022
@patchback
wafv2_web_acl - fix return values (#1216) (#1227)
9e84535 
[PR #1216/01f32747 backport][stable-3] wafv2_web_acl - fix return values

This is a backport of PR #1216 as merged into main (01f3274).
SUMMARY

split integration tests from full wafv2 tests
relax botocore requirement to bare minimum required
return web acl info on update
consistently return web acl info as described in documentation (create would nest it under "web_acl")
fix "changed" value when description not specified

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_web_acl
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
@tremble tremble deleted the wafv2_web_acl/description branch July 7, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@markuman markuman Awaiting requested review from markuman

@jatorcasso jatorcasso Awaiting requested review from jatorcasso

Assignees
No one assigned
Labels
backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremble @ansibullbot @alinabuzachis @jatorcasso