Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudtrail - add support for purge_tags #1219

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 5, 2022

SUMMARY
  • Move to tagging docs fragment
  • Update tagging code so that "tags" must be explicitly passed to remove tags
  • add purge_tags parameter
  • add resource_tags as an alias for tags
  • Update tagging code so that tags are set as part of the create call rather than tagging after creation
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cloudtrail

ADDITIONAL INFORMATION

Note: tests are currently not run in CI.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 5, 2022
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 06s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 43s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 55s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 03s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 29s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 33s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 27s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 45s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 48s
✔️ ansible-test-splitter SUCCESS in 2m 33s
✔️ integration-community.aws-1 SUCCESS in 5m 10s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 47s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 43s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 28s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 46s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 52s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 40s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 27s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 45s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 42s
✔️ ansible-test-splitter SUCCESS in 2m 56s
✔️ integration-community.aws-1 SUCCESS in 5m 12s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 53e3bb2 into ansible-collections:main Jun 7, 2022
@tremble tremble deleted the tagging/purge/cloudtrail branch July 7, 2022 19:23
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
cloudtrail - add support for purge_tags

SUMMARY

Move to tagging docs fragment
Update tagging code so that "tags" must be explicitly passed to remove tags
add purge_tags parameter
add resource_tags as an alias for tags
Update tagging code so that tags are set as part of the create call rather than tagging after creation

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
cloudtrail
ADDITIONAL INFORMATION
Note: tests are currently not run in CI.

Reviewed-by: Joseph Torcasso <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@53e3bb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants