Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_vgw - Add support for purge_tags #1232

Merged
merged 1 commit into from
Jun 9, 2022
Merged

ec2_vpc_vgw - Add support for purge_tags #1232

merged 1 commit into from
Jun 9, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 8, 2022 •
edited
Loading

SUMMARY
  • Adds support for purge_tags to ec2_vpc_vgw
  • Updates behaviour so that tags must be explicitly set to {} to remove tags
  • Updates ec2_vpc_vgw to pass tags as part of the VGW creation rather than tagging the VGW after creation.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_vgw
ec2_vpc_vgw_info

ADDITIONAL INFORMATION
  • return docs
  • changelog

@ansibullbot
Copy link

cc @jillr @markuman @naslanidis @s-hertel
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@tremble tremble force-pushed the tagging/purge/ec2_vpc_vgw branch from 53bde24 to 87c6319 Compare June 8, 2022 19:03
@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@tremble tremble force-pushed the tagging/purge/ec2_vpc_vgw branch from 87c6319 to 989f17a Compare June 9, 2022 07:33
@tremble tremble requested a review from markuman June 9, 2022 07:34
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 4m 11s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 37s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 21s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 58s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 34s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 28s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 14s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 59s
✔️ ansible-test-splitter SUCCESS in 2m 27s
✔️ integration-community.aws-1 SUCCESS in 5m 18s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 9, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 3m 58s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 53s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 34s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 13s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 42s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 45s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 21s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 08s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 00s
✔️ ansible-test-splitter SUCCESS in 2m 23s
✔️ integration-community.aws-1 SUCCESS in 5m 05s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7ca53c7 into ansible-collections:main Jun 9, 2022
@renovate renovate bot mentioned this pull request Jun 24, 2022
Merged
1 task
@tremble tremble deleted the tagging/purge/ec2_vpc_vgw branch July 7, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@jatorcasso jatorcasso Awaiting requested review from jatorcasso

@markuman markuman Awaiting requested review from markuman

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @alinabuzachis