route53_info: Add RETURN block #1240

mandar242 · 2022-06-15T21:31:09Z

SUMMARY

Currently route53_info is mising a return block.

This is a follow up on #1236

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

route53_info

ansibullbot · 2022-06-15T21:35:34Z

cc @Etherdaemon @jillr @markuman @s-hertel @tremble
click here for bot help

github-actions · 2022-06-15T21:38:46Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2022-06-15T21:53:04Z

Build succeeded.

jatorcasso

can you please add version_added since these are new return values. Also, is it worth documenting the deprecated return values? Im not sure if thats necessary or not

mandar242 · 2022-06-15T23:39:36Z

can you please add version_added since these are new return values. Also, is it worth documenting the deprecated return values? Im not sure if thats necessary or not

sure added version_added. I'm not sure which values you mean here 'documenting the deprecated return values' ?

softwarefactory-project-zuul · 2022-06-15T23:56:24Z

Build succeeded.

jatorcasso · 2022-06-16T00:03:54Z

can you please add version_added since these are new return values. Also, is it worth documenting the deprecated return values? Im not sure if thats necessary or not

sure added version_added. I'm not sure which values you mean here 'documenting the deprecated return values' ?

The CamelCased keys that will still be returned until we remove them

gravesm · 2022-06-16T12:31:58Z

I would document the deprecated keys with a note about the deprecation, but skip adding the contains block for them. I think it's worth telling users about their existence, but we don't need the full documentation for them

softwarefactory-project-zuul · 2022-06-16T20:00:46Z

Build succeeded.

jatorcasso

I think version added should be 3.4.0 if I'm not mistaken - aside from that LGTM!

plugins/modules/route53_info.py

softwarefactory-project-zuul · 2022-06-17T16:42:00Z

Build succeeded.

softwarefactory-project-zuul · 2022-06-17T21:11:49Z

Build succeeded (gate pipeline).

route53_info: Add RETURN block SUMMARY Currently route53_info is mising a return block. This is a follow up on ansible-collections#1236 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Mandar Kulkarni <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@6e7f150

mandar242 added 2 commits June 15, 2022 14:27

Add RETURN block info to route53_info

a3d3631

Add changelogs fragment

774529d

ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) labels Jun 15, 2022

jatorcasso reviewed Jun 15, 2022

View reviewed changes

Add version_added to return values

2fc3c5e

Add deprecated return values to RETURN block

b5b050f

mandar242 requested review from jatorcasso and gravesm June 16, 2022 19:48

jatorcasso approved these changes Jun 16, 2022

View reviewed changes

gravesm reviewed Jun 17, 2022

View reviewed changes

plugins/modules/route53_info.py Outdated Show resolved Hide resolved

Add specific release version for deprecation messages

d8e8f76

mandar242 requested a review from gravesm June 17, 2022 16:25

gravesm approved these changes Jun 17, 2022

View reviewed changes

mandar242 added the mergeit Merge the PR (SoftwareFactory) label Jun 17, 2022

softwarefactory-project-zuul bot merged commit 6e7f150 into ansible-collections:main Jun 17, 2022

mandar242 deleted the route53_info_return_block branch June 17, 2022 21:42

renovate bot mentioned this pull request Jun 24, 2022

chore(deps): update dependency community.aws to v4 linxside/ansible-ee#34

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

route53_info: Add RETURN block #1240

route53_info: Add RETURN block #1240

mandar242 commented Jun 15, 2022 •

edited

Loading

ansibullbot commented Jun 15, 2022

github-actions bot commented Jun 15, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Jun 15, 2022

jatorcasso left a comment

mandar242 commented Jun 15, 2022

softwarefactory-project-zuul bot commented Jun 15, 2022

jatorcasso commented Jun 16, 2022

gravesm commented Jun 16, 2022

softwarefactory-project-zuul bot commented Jun 16, 2022

jatorcasso left a comment

softwarefactory-project-zuul bot commented Jun 17, 2022

softwarefactory-project-zuul bot commented Jun 17, 2022

route53_info: Add RETURN block #1240

route53_info: Add RETURN block #1240

Conversation

mandar242 commented Jun 15, 2022 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ansibullbot commented Jun 15, 2022

github-actions bot commented Jun 15, 2022 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Jun 15, 2022

jatorcasso left a comment

Choose a reason for hiding this comment

mandar242 commented Jun 15, 2022

softwarefactory-project-zuul bot commented Jun 15, 2022

jatorcasso commented Jun 16, 2022

gravesm commented Jun 16, 2022

softwarefactory-project-zuul bot commented Jun 16, 2022

jatorcasso left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jun 17, 2022

softwarefactory-project-zuul bot commented Jun 17, 2022

mandar242 commented Jun 15, 2022 •

edited

Loading

github-actions bot commented Jun 15, 2022 •

edited

Loading