ec2_vpc_vpn - fix exception when running in check mode without tags set #1242

tremble · 2022-06-19T20:16:05Z

SUMMARY

Rename ec2_vpc_vpn_info tests to ec2_vpc_vpn so we have baseline testing for VPNs (keep ec2_vpc_vpn_info as an alias)
fix exception when run in check mode without tags set.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_vpc_vpn

ADDITIONAL INFORMATION

TASK [ec2_vpc_vpn : (check) No change to tags without setting tags] ************
task path: /root/ansible_collections/community/aws/tests/output/.tmp/integration/ec2_vpc_vpn-oywt620e-ÅÑŚÌβŁÈ/tests/integration/targets/ec2_vpc_vpn/tasks/tags.yml:248
Using module file /root/ansible_collections/community/aws/plugins/modules/ec2_vpc_vpn.py
Pipelining is enabled.
<testhost> ESTABLISH LOCAL CONNECTION FOR USER: root
<testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /usr/bin/python3.10 && sleep 0'
The full traceback is:
Traceback (most recent call last):
  File "<stdin>", line 121, in <module>
  File "<stdin>", line 113, in _ansiballz_main
  File "<stdin>", line 61, in invoke_module
  File "/usr/lib/python3.10/runpy.py", line 209, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.10/runpy.py", line 96, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/tmp/ansible_ec2_vpc_vpn_payload_0zo_xg79/ansible_ec2_vpc_vpn_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vpn.py", line 808, in <module>
  File "/tmp/ansible_ec2_vpc_vpn_payload_0zo_xg79/ansible_ec2_vpc_vpn_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vpn.py", line 795, in main
  File "/tmp/ansible_ec2_vpc_vpn_payload_0zo_xg79/ansible_ec2_vpc_vpn_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vpn.py", line 714, in ensure_present
  File "/tmp/ansible_ec2_vpc_vpn_payload_0zo_xg79/ansible_ec2_vpc_vpn_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vpn.py", line 661, in get_check_mode_results
AttributeError: 'NoneType' object has no attribute 'keys'
fatal: [testhost]: FAILED! => {
    "changed": false,
    "module_stderr": "Traceback (most recent call last):\n  File \"<stdin>\", line 121, in <module>\n  File \"<stdin>\", line 113, in _ansiballz_main\n  File \"<stdin>\", line 61, in invoke_module\n  File \"/usr/lib/python3.10/runpy.py\", line 209, in run_module\n    return _run_module_code(code, init_globals, run_name, mod_spec)\n  File \"/usr/lib/python3.10/runpy.py\", line 96, in _run_module_code\n    _run_code(code, mod_globals, init_globals,\n  File \"/usr/lib/python3.10/runpy.py\", line 86, in _run_code\n    exec(code, run_globals)\n  File \"/tmp/ansible_ec2_vpc_vpn_payload_0zo_xg79/ansible_ec2_vpc_vpn_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vpn.py\", line 808, in <module>\n  File \"/tmp/ansible_ec2_vpc_vpn_payload_0zo_xg79/ansible_ec2_vpc_vpn_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vpn.py\", line 795, in main\n  File \"/tmp/ansible_ec2_vpc_vpn_payload_0zo_xg79/ansible_ec2_vpc_vpn_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vpn.py\", line 714, in ensure_present\n  File \"/tmp/ansible_ec2_vpc_vpn_payload_0zo_xg79/ansible_ec2_vpc_vpn_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vpn.py\", line 661, in get_check_mode_results\nAttributeError: 'NoneType' object has no attribute 'keys'\n",
    "module_stdout": "",
    "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
    "rc": 1
}

ansibullbot · 2022-06-19T20:22:57Z

cc @Madhura-CSI @jillr @markuman @s-hertel
click here for bot help

softwarefactory-project-zuul · 2022-06-19T20:35:10Z

Build succeeded.

softwarefactory-project-zuul · 2022-06-20T09:18:40Z

Build succeeded (gate pipeline).

tox: add description Reviewed-by: Mark Chappell <None>

tremble added 3 commits June 19, 2022 19:43

Enable ec2_vpc_vpn integration tests

ebea6c5

Add tagging tests for ec2_vpc_vpn

9edb067

Fix exception when tags not passed in check mode

2ca8cc9

tremble force-pushed the tests/ec2_vpc_vpn branch from b8f24b9 to 2ca8cc9 Compare June 19, 2022 20:17

ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) python3 tests tests traceback labels Jun 19, 2022

tremble requested review from alinabuzachis, markuman and jatorcasso June 20, 2022 06:47

alinabuzachis approved these changes Jun 20, 2022

View reviewed changes

tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 20, 2022

softwarefactory-project-zuul bot merged commit 3433640 into ansible-collections:main Jun 20, 2022

renovate bot mentioned this pull request Jun 24, 2022

chore(deps): update dependency community.aws to v4 linxside/ansible-ee#34

Merged

1 task

tremble deleted the tests/ec2_vpc_vpn branch July 7, 2022 19:26

abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023

tox: add description (ansible-collections#1242)

df44023

tox: add description Reviewed-by: Mark Chappell <None>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ec2_vpc_vpn - fix exception when running in check mode without tags set #1242

ec2_vpc_vpn - fix exception when running in check mode without tags set #1242

tremble commented Jun 19, 2022

ansibullbot commented Jun 19, 2022

softwarefactory-project-zuul bot commented Jun 19, 2022

softwarefactory-project-zuul bot commented Jun 20, 2022

ec2_vpc_vpn - fix exception when running in check mode without tags set #1242

ec2_vpc_vpn - fix exception when running in check mode without tags set #1242

Conversation

tremble commented Jun 19, 2022

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jun 19, 2022

softwarefactory-project-zuul bot commented Jun 19, 2022

softwarefactory-project-zuul bot commented Jun 20, 2022